Re: [PATCH v2] rust: Return Option from page_align and ensure no usize overflow

[Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>]

On Thu, Nov 27, 2025 at 3:41 PM Brendan Shephard <bshephar@bne-home.net> wrote:
>
> Changes in v2:
>   - Reworded commit message to follow the imperative form.
>   - Expanded the documentation to explain the `Some` and `None` return cases.
>   - Added a period at the end of the documentation comment.

This shouldn't be in the commit message. It should instead be placed
below the first `---` line (the one below the Signed-off-by).

Also, I would recommend not replying to the previous version but
starting a new thread instead (it is good to provide a lore.kernel.org
to the previous version in the change log).

In addition, if possible, it is nice to use `--base` to tell Git to
provide the base commit.

> +/// Return Some [`usize`] that is page aligned. Or None in cases where the next multiple of
> +/// [`PAGE_SIZE`] would overflow a [`usize`].

Missing intra-doc link (this was feedback in v1). In addition, this
reads a bit strangely, and it looks like the first line of the
description wasn't removed? That would make the "short description"
(the first paragraph) quite long. Please generate the docs to see if
it looks good when generated.

More importantly, please add some examples (doctests). They are tested
as KUnit tests automatically. For new APIs, we always try to do add
examples, and in cases where there are edge cases like here, it
clarifies quite a bit, i.e. please provide a representative example of
the `Some` case and the `None` case.

Thanks!

Cheers,
Miguel