Re: [PATCH v4] rust: introduce sfile macro for succinct code tracing

[Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>]

On Wed, Jun 18, 2025 at 10:05 PM Timur Tabi <ttabi@nvidia.com> wrote:
>
> I'm having trouble coding this up.  I have this so far, but it doesn't compile:

(snip)

> 492 |             unsafe { core::str::from_utf8_unchecked(p) }
>     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `Option<&str>`, found `&str`

If you are asking about that last line, you need to return a `Some(...)`.

If you are asking in general, then since now you can return `None`,
you can just call the safe `from_utf8` and convert to an `Option`,
which also allows you to avoid the `is_ascii` call, and also allows
you to return `None` in other cases above too (instead of panicking).

That also allows you to keep the macro straightforward and small.

I hope that helps.

Cheers,
Miguel