From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Tamir Duberstein <tamird@gmail.com>
Cc: "Masahiro Yamada" <masahiroy@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Brendan Higgins" <brendan.higgins@linux.dev>,
"David Gow" <davidgow@google.com>, "Rae Moar" <rmoar@google.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Russ Weight" <russ.weight@linux.dev>,
"Rob Herring" <robh@kernel.org>,
"Saravana Kannan" <saravanak@google.com>,
"Abdiel Janulgue" <abdiel.janulgue@gmail.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"FUJITA Tomonori" <fujita.tomonori@gmail.com>,
"Nicolas Schier" <nicolas.schier@linux.dev>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Lyude Paul" <lyude@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Anna-Maria Behnsen" <anna-maria@linutronix.de>,
"Benno Lossin" <lossin@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"John Stultz" <jstultz@google.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-pci@vger.kernel.org,
linux-block@vger.kernel.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, netdev@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v11 0/6] rust: reduce `as` casts, enable related lints
Date: Fri, 13 Jun 2025 20:14:41 +0200 [thread overview]
Message-ID: <CANiq72m1ZWxPgCda1C-8X5XOvEq9Z9JfJZqhU4ZUzZ64=N+2fQ@mail.gmail.com> (raw)
In-Reply-To: <20250611-ptr-as-ptr-v11-0-ce5b41c6e9c6@gmail.com>
On Wed, Jun 11, 2025 at 12:23 PM Tamir Duberstein <tamird@gmail.com> wrote:
>
> This series depends on "rust: retain pointer mut-ness in
> `container_of!`"[1].
Not anymore! :)
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
Thanks for rebasing, Tamir, I appreciate it.
This has a bunch of hits in configfs, cpufreq and Nova [1]. I guess
you built without those enabled.
Could you please fix those? Since this affects other maintainers that
we need to ask the Acked-by to, let's try to at least give them the
final state.
Thanks!
Cheers,
Miguel
[1]
warning: reference as raw pointer
--> rust/kernel/configfs.rs:429:9
warning: reference as raw pointer
--> rust/kernel/configfs.rs:467:9
warning: reference as raw pointer
--> rust/kernel/configfs.rs:479:9
warning: `as` casting between raw pointers without changing their constness
--> rust/kernel/configfs.rs:564:48
warning: reference as raw pointer
--> rust/kernel/configfs.rs:721:39
warning: reference as raw pointer
--> rust/kernel/configfs.rs:764:35
warning: reference as raw pointer
--> rust/kernel/configfs.rs:783:35
warning: reference as raw pointer
--> rust/kernel/configfs.rs:764:35
warning: reference as raw pointer
--> rust/kernel/configfs.rs:783:35
warning: using `as _` conversion
--> rust/kernel/cpufreq.rs:650:45
warning: `as` casting between raw pointers without changing their constness
--> rust/kernel/cpufreq.rs:650:45
warning: using `as _` conversion
--> drivers/gpu/nova-core/driver.rs:22:64
warning: casts from `u8` to `u32` can be expressed infallibly using `From`
--> drivers/gpu/nova-core/regs/macros.rs:267:26
warning: casts from `u8` to `u32` can be expressed infallibly using `From`
--> drivers/gpu/nova-core/regs/macros.rs:267:26
warning: casts from `u8` to `u32` can be expressed infallibly using `From`
--> drivers/gpu/nova-core/regs/macros.rs:267:26
warning: casts from `u8` to `u32` can be expressed infallibly using `From`
--> drivers/gpu/nova-core/regs/macros.rs:267:26
warning: casts from `u8` to `u32` can be expressed infallibly using `From`
--> drivers/gpu/nova-core/regs/macros.rs:267:26
warning: casts from `u8` to `u32` can be expressed infallibly using `From`
--> drivers/gpu/nova-core/regs.rs:35:65
next prev parent reply other threads:[~2025-06-13 18:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 10:23 [PATCH v11 0/6] rust: reduce `as` casts, enable related lints Tamir Duberstein
2025-06-11 10:23 ` [PATCH v11 1/6] rust: enable `clippy::ptr_as_ptr` lint Tamir Duberstein
2025-06-11 10:23 ` [PATCH v11 2/6] rust: enable `clippy::ptr_cast_constness` lint Tamir Duberstein
2025-06-11 10:23 ` [PATCH v11 3/6] rust: enable `clippy::as_ptr_cast_mut` lint Tamir Duberstein
2025-06-11 10:23 ` [PATCH v11 4/6] rust: enable `clippy::as_underscore` lint Tamir Duberstein
2025-06-11 10:23 ` [PATCH v11 5/6] rust: enable `clippy::cast_lossless` lint Tamir Duberstein
2025-06-11 10:23 ` [PATCH v11 6/6] rust: enable `clippy::ref_as_ptr` lint Tamir Duberstein
2025-06-13 18:14 ` Miguel Ojeda [this message]
2025-06-15 20:41 ` [PATCH v11 0/6] rust: reduce `as` casts, enable related lints Tamir Duberstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72m1ZWxPgCda1C-8X5XOvEq9Z9JfJZqhU4ZUzZ64=N+2fQ@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=abdiel.janulgue@gmail.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=jstultz@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=kwilczynski@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mripard@kernel.org \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.schier@linux.dev \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rmoar@google.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=russ.weight@linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=simona@ffwll.ch \
--cc=tamird@gmail.com \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).