* [PATCH] rust: helpers: Fix grammar in comment
@ 2024-04-11 20:54 Thorsten Blum
2024-04-12 11:05 ` Alice Ryhl
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thorsten Blum @ 2024-04-11 20:54 UTC (permalink / raw)
To: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
Alice Ryhl
Cc: rust-for-linux, linux-kernel, Thorsten Blum
s/directly the bindings/the bindings directly/
Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
rust/helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/helpers.c b/rust/helpers.c
index 70e59efd92bc..4c8b7b92a4f4 100644
--- a/rust/helpers.c
+++ b/rust/helpers.c
@@ -4,7 +4,7 @@
* cannot be called either. This file explicitly creates functions ("helpers")
* that wrap those so that they can be called from Rust.
*
- * Even though Rust kernel modules should never use directly the bindings, some
+ * Even though Rust kernel modules should never use the bindings directly, some
* of these helpers need to be exported because Rust generics and inlined
* functions may not get their code generated in the crate where they are
* defined. Other helpers, called from non-inline functions, may not be
--
2.44.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rust: helpers: Fix grammar in comment
2024-04-11 20:54 [PATCH] rust: helpers: Fix grammar in comment Thorsten Blum
@ 2024-04-12 11:05 ` Alice Ryhl
2024-04-16 5:59 ` Trevor Gross
2024-05-05 22:28 ` Miguel Ojeda
2 siblings, 0 replies; 4+ messages in thread
From: Alice Ryhl @ 2024-04-12 11:05 UTC (permalink / raw)
To: Thorsten Blum
Cc: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
rust-for-linux, linux-kernel
On Thu, Apr 11, 2024 at 10:55 PM Thorsten Blum <thorsten.blum@toblux.com> wrote:
>
> s/directly the bindings/the bindings directly/
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
> rust/helpers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/helpers.c b/rust/helpers.c
> index 70e59efd92bc..4c8b7b92a4f4 100644
> --- a/rust/helpers.c
> +++ b/rust/helpers.c
> @@ -4,7 +4,7 @@
> * cannot be called either. This file explicitly creates functions ("helpers")
> * that wrap those so that they can be called from Rust.
> *
> - * Even though Rust kernel modules should never use directly the bindings, some
> + * Even though Rust kernel modules should never use the bindings directly, some
> * of these helpers need to be exported because Rust generics and inlined
> * functions may not get their code generated in the crate where they are
> * defined. Other helpers, called from non-inline functions, may not be
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rust: helpers: Fix grammar in comment
2024-04-11 20:54 [PATCH] rust: helpers: Fix grammar in comment Thorsten Blum
2024-04-12 11:05 ` Alice Ryhl
@ 2024-04-16 5:59 ` Trevor Gross
2024-05-05 22:28 ` Miguel Ojeda
2 siblings, 0 replies; 4+ messages in thread
From: Trevor Gross @ 2024-04-16 5:59 UTC (permalink / raw)
To: Thorsten Blum
Cc: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
Alice Ryhl, rust-for-linux, linux-kernel
On Thu, Apr 11, 2024 at 4:55 PM Thorsten Blum <thorsten.blum@toblux.com> wrote:
>
> s/directly the bindings/the bindings directly/
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
Reviewed-by: Trevor Gross <tmgross@umich.edu>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rust: helpers: Fix grammar in comment
2024-04-11 20:54 [PATCH] rust: helpers: Fix grammar in comment Thorsten Blum
2024-04-12 11:05 ` Alice Ryhl
2024-04-16 5:59 ` Trevor Gross
@ 2024-05-05 22:28 ` Miguel Ojeda
2 siblings, 0 replies; 4+ messages in thread
From: Miguel Ojeda @ 2024-05-05 22:28 UTC (permalink / raw)
To: Thorsten Blum
Cc: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
Alice Ryhl, rust-for-linux, linux-kernel
On Thu, Apr 11, 2024 at 10:55 PM Thorsten Blum <thorsten.blum@toblux.com> wrote:
>
> s/directly the bindings/the bindings directly/
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
Applied to `rust-next` -- thanks everyone!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-05 22:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-11 20:54 [PATCH] rust: helpers: Fix grammar in comment Thorsten Blum
2024-04-12 11:05 ` Alice Ryhl
2024-04-16 5:59 ` Trevor Gross
2024-05-05 22:28 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).