REGRESSION: armv7 build mismatched types

REGRESSION: armv7 build mismatched types

[Rudraksha Gupta]

Logs: https://gitlab.postmarketos.org/LogicalErzor/pmaports/-/jobs/1368490

Archive: 
https://web.archive.org/web/20250530060232/https://gitlab.postmarketos.org/LogicalErzor/pmaports/-/jobs/1368490/raw


Snip:

||

|EXPORTS rust/exports_core_generated.h|
|
||
RUSTC L rust/compiler_builtins.o
||
RUSTC L rust/ffi.o
||
RUSTC L rust/build_error.o
||
RUSTC L rust/pin_init.o
||
RUSTC L rust/bindings.o
||
RUSTC L rust/uapi.o
||
EXPORTS rust/exports_bindings_generated.h
||
RUSTC L rust/kernel.o
||
error[E0308]: mismatched types
||
--> rust/kernel/lib.rs:234:45
||
|
||
234 | $crate::assert_same_type(field_ptr, (&raw const 
(*container_ptr).$($fields)*).cast_mut());
||
| ------------------------ --------- 
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `*const 
drm_device`, found `*mut Opaque<drm_device>`
||
| | |
||
| | expected all arguments to be this `*const drm_device` type because 
they need to match the type of this parameter
||
| arguments to this function are incorrect
||
|
||
::: rust/kernel/drm/device.rs:140:18
||
|
||
140 | unsafe { crate::container_of!(ptr, Self, dev) }.cast_mut()
||
| ------------------------------------ in this macro invocation
||
|
||
= note: expected raw pointer `*const drm_device`
||
found raw pointer `*mut Opaque<drm_device>`
||
note: function defined here
||
--> rust/kernel/lib.rs:241:8
||
|
||
241 | pub fn assert_same_type<T>(_: T, _: T) {}
||
| ^^^^^^^^^^^^^^^^ - ---- ---- this parameter needs to match the `*const 
drm_device` type of parameter #1
||
| | |
||
| | parameter #2 needs to match the `*const drm_device` type of this 
parameter
||
| parameter #1 and parameter #2 both reference this parameter `T`
||
= note: this error originates in the macro `crate::container_of` (in 
Nightly builds, run with -Z macro-backtrace for more info)
||
error[E0308]: mismatched types
||
--> rust/kernel/lib.rs:234:45
||
|
||
234 | $crate::assert_same_type(field_ptr, (&raw const 
(*container_ptr).$($fields)*).cast_mut());
||
| ------------------------ --------- 
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `*mut 
drm_gem_object`, found `*mut Opaque<drm_gem_object>`
||
| | |
||
| | expected all arguments to be this `*mut drm_gem_object` type because 
they need to match the type of this parameter
||
| arguments to this function are incorrect
||
|
||
::: rust/kernel/drm/gem/mod.rs:130:20
||
|
||
130 | unsafe { &*crate::container_of!(self_ptr, Object<T>, obj) }
||
| ---------------------------------------------- in this macro invocation
||
|
||
= note: expected raw pointer `*mut drm_gem_object`
||
found raw pointer `*mut Opaque<drm_gem_object>`
||
note: function defined here
||
--> rust/kernel/lib.rs:241:8
||
|
||
241 | pub fn assert_same_type<T>(_: T, _: T) {}
||
| ^^^^^^^^^^^^^^^^ - ---- ---- this parameter needs to match the `*mut 
drm_gem_object` type of parameter #1
||
| | |
||
| | parameter #2 needs to match the `*mut drm_gem_object` type of this 
parameter
||
| parameter #1 and parameter #2 both reference this parameter `T`
||
= note: this error originates in the macro `crate::container_of` (in 
Nightly builds, run with -Z macro-backtrace for more info)
||
error[E0308]: mismatched types
||
--> rust/kernel/lib.rs:234:45
||
|
||
234 | $crate::assert_same_type(field_ptr, (&raw const 
(*container_ptr).$($fields)*).cast_mut());
||
| ------------------------ --------- 
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `*mut 
drm_gem_object`, found `*mut Opaque<drm_gem_object>`
||
| | |
||
| | expected all arguments to be this `*mut drm_gem_object` type because 
they need to match the type of this parameter
||
| arguments to this function are incorrect
||
|
||
::: rust/kernel/drm/gem/mod.rs:273:29
||
|
||
273 | let this = unsafe { crate::container_of!(obj, Self, obj) };
||
| ------------------------------------ in this macro invocation
||
|
||
= note: expected raw pointer `*mut drm_gem_object`
||
found raw pointer `*mut Opaque<drm_gem_object>`
||
note: function defined here
||
--> rust/kernel/lib.rs:241:8
||
|
||
241 | pub fn assert_same_type<T>(_: T, _: T) {}
||
| ^^^^^^^^^^^^^^^^ - ---- ---- this parameter needs to match the `*mut 
drm_gem_object` type of parameter #1
||
| | |
||
| | parameter #2 needs to match the `*mut drm_gem_object` type of this 
parameter
||
| parameter #1 and parameter #2 both reference this parameter `T`
||
= note: this error originates in the macro `crate::container_of` (in 
Nightly builds, run with -Z macro-backtrace for more info)
||
error: aborting due to 3 previous errors
||
For more information about this error, try `rustc --explain E0308`.
||
make[2]: *** [rust/Makefile:538: rust/kernel.o] Error 1
||
make[1]: *** 
[/home/pmos/build/src/linux-next-next-20250530/Makefile:1285: prepare] 
Error 2
||make: *** [Makefile:248: __sub-make] Error 2|


Bad: next-20250530

Good: next-20250528


Likely introduced with: 
https://lore.kernel.org/all/CANiq72mFiCrzawVUVOU2giJtBVsRdAO3sGtDsZptPuFvmid3EQ@mail.gmail.com/


Repo: 
https://gitlab.postmarketos.org/LogicalErzor/pmaports/-/tree/rust/device/testing/linux-next

How it's built (Alpine-like build system):

- https://archive.ph/vxEmk

Config fragments (in addition to qcom_defconfig):

- https://archive.ph/q4hfc

- https://archive.ph/RKgFf

Re: REGRESSION: armv7 build mismatched types

[Rudraksha Gupta]

Unsure why the formatting got messed up. Retrying a second time (if this 
doesn't work, please look at the logs and excuse me).


   RUSTC L rust/ffi.o
   RUSTC L rust/build_error.o
   RUSTC L rust/pin_init.o
   RUSTC L rust/bindings.o
   RUSTC L rust/uapi.o
   EXPORTS rust/exports_bindings_generated.h
   RUSTC L rust/kernel.o
error[E0308]: mismatched types
    --> rust/kernel/lib.rs:234:45
     |
234 |         $crate::assert_same_type(field_ptr, (&raw const 
(*container_ptr).$($fields)*).cast_mut());
     |         ------------------------ --------- 
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `*const 
drm_device`, found `*mut Opaque<drm_device>`
     |         |                        |
     |         |                        expected all arguments to be 
this `*const drm_device` type because they need to match the type of 
this parameter
     |         arguments to this function are incorrect
     |
    ::: rust/kernel/drm/device.rs:140:18
     |
140 |         unsafe { crate::container_of!(ptr, Self, dev) }.cast_mut()
     |                  ------------------------------------ in this 
macro invocation
     |
     = note: expected raw pointer `*const drm_device`
                found raw pointer `*mut Opaque<drm_device>`
note: function defined here
    --> rust/kernel/lib.rs:241:8
     |
241 | pub fn assert_same_type<T>(_: T, _: T) {}
     |        ^^^^^^^^^^^^^^^^ -  ----  ---- this parameter needs to 
match the `*const drm_device` type of parameter #1
     |                         |  |
     |                         |  parameter #2 needs to match the 
`*const drm_device` type of this parameter
     |                         parameter #1 and parameter #2 both 
reference this parameter `T`
     = note: this error originates in the macro `crate::container_of` 
(in Nightly builds, run with -Z macro-backtrace for more info)

error[E0308]: mismatched types
    --> rust/kernel/lib.rs:234:45
     |
234 |         $crate::assert_same_type(field_ptr, (&raw const 
(*container_ptr).$($fields)*).cast_mut());
     |         ------------------------ --------- 
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `*mut 
drm_gem_object`, found `*mut Opaque<drm_gem_object>`
     |         |                        |
     |         |                        expected all arguments to be 
this `*mut drm_gem_object` type because they need to match the type of 
this parameter
     |         arguments to this function are incorrect
     |
    ::: rust/kernel/drm/gem/mod.rs:130:20
     |
130 |         unsafe { &*crate::container_of!(self_ptr, Object<T>, obj) }
     | ---------------------------------------------- in this macro 
invocation
     |
     = note: expected raw pointer `*mut drm_gem_object`
                found raw pointer `*mut Opaque<drm_gem_object>`
note: function defined here
    --> rust/kernel/lib.rs:241:8
     |
241 | pub fn assert_same_type<T>(_: T, _: T) {}
     |        ^^^^^^^^^^^^^^^^ -  ----  ---- this parameter needs to 
match the `*mut drm_gem_object` type of parameter #1
     |                         |  |
     |                         |  parameter #2 needs to match the `*mut 
drm_gem_object` type of this parameter
     |                         parameter #1 and parameter #2 both 
reference this parameter `T`
     = note: this error originates in the macro `crate::container_of` 
(in Nightly builds, run with -Z macro-backtrace for more info)

error[E0308]: mismatched types
    --> rust/kernel/lib.rs:234:45
     |
234 |         $crate::assert_same_type(field_ptr, (&raw const 
(*container_ptr).$($fields)*).cast_mut());
     |         ------------------------ --------- 
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `*mut 
drm_gem_object`, found `*mut Opaque<drm_gem_object>`
     |         |                        |
     |         |                        expected all arguments to be 
this `*mut drm_gem_object` type because they need to match the type of 
this parameter
     |         arguments to this function are incorrect
     |
    ::: rust/kernel/drm/gem/mod.rs:273:29
     |
273 |         let this = unsafe { crate::container_of!(obj, Self, obj) };
     | ------------------------------------ in this macro invocation
     |
     = note: expected raw pointer `*mut drm_gem_object`
                found raw pointer `*mut Opaque<drm_gem_object>`
note: function defined here
    --> rust/kernel/lib.rs:241:8
     |
241 | pub fn assert_same_type<T>(_: T, _: T) {}
     |        ^^^^^^^^^^^^^^^^ -  ----  ---- this parameter needs to 
match the `*mut drm_gem_object` type of parameter #1
     |                         |  |
     |                         |  parameter #2 needs to match the `*mut 
drm_gem_object` type of this parameter
     |                         parameter #1 and parameter #2 both 
reference this parameter `T`
     = note: this error originates in the macro `crate::container_of` 
(in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to 3 previous errors

For more information about this error, try `rustc --explain E0308`.
make[2]: *** [rust/Makefile:538: rust/kernel.o] Error 1
make[1]: *** 
[/home/pmos/build/src/linux-next-next-20250530/Makefile:1285: prepare] 
Error 2
make: *** [Makefile:248: __sub-make] Error 2

Re: REGRESSION: armv7 build mismatched types

[Thorsten Leemhuis]

CCing linux-next and Tamir Duberstein, who authored the culprit.

On 30.05.25 08:23, Rudraksha Gupta wrote:
> Logs: https://gitlab.postmarketos.org/LogicalErzor/pmaports/-/jobs/1368490
> 
> Archive: https://web.archive.org/web/20250530060232/https://
> gitlab.postmarketos.org/LogicalErzor/pmaports/-/jobs/1368490/raw

I ran into the same error on aarch64 and x86_64 when building -next for
Fedora today using the rawhide config:

https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-rawhide-x86_64/09103515-next-next-all/builder-live.log.gz
https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-rawhide-aarch64/09103515-next-next-all/builder-live.log.gz

Reverting b20fbbc08a363f ("rust: check type of `$ptr` in
`container_of!`") fixed things. That's the patch Rudraksha suspected to
be the root of the problem (see the quote below).

Ciao, Thorsten

> Snip:
> 
> ||
> 
> |EXPORTS rust/exports_core_generated.h|
> |
> ||
> RUSTC L rust/compiler_builtins.o
> ||
> RUSTC L rust/ffi.o
> ||
> RUSTC L rust/build_error.o
> ||
> RUSTC L rust/pin_init.o
> ||
> RUSTC L rust/bindings.o
> ||
> RUSTC L rust/uapi.o
> ||
> EXPORTS rust/exports_bindings_generated.h
> ||
> RUSTC L rust/kernel.o
> ||
> error[E0308]: mismatched types
> ||
> --> rust/kernel/lib.rs:234:45
> ||
> |
> ||
> 234 | $crate::assert_same_type(field_ptr, (&raw const (*container_ptr).
> $($fields)*).cast_mut());
> ||
> | ------------------------ ---------
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `*const
> drm_device`, found `*mut Opaque<drm_device>`
> ||
> | | |
> ||
> | | expected all arguments to be this `*const drm_device` type because
> they need to match the type of this parameter
> ||
> | arguments to this function are incorrect
> ||
> |
> ||
> ::: rust/kernel/drm/device.rs:140:18
> ||
> |
> ||
> 140 | unsafe { crate::container_of!(ptr, Self, dev) }.cast_mut()
> ||
> | ------------------------------------ in this macro invocation
> ||
> |
> ||
> = note: expected raw pointer `*const drm_device`
> ||
> found raw pointer `*mut Opaque<drm_device>`
> ||
> note: function defined here
> ||
> --> rust/kernel/lib.rs:241:8
> ||
> |
> ||
> 241 | pub fn assert_same_type<T>(_: T, _: T) {}
> ||
> | ^^^^^^^^^^^^^^^^ - ---- ---- this parameter needs to match the `*const
> drm_device` type of parameter #1
> ||
> | | |
> ||
> | | parameter #2 needs to match the `*const drm_device` type of this
> parameter
> ||
> | parameter #1 and parameter #2 both reference this parameter `T`
> ||
> = note: this error originates in the macro `crate::container_of` (in
> Nightly builds, run with -Z macro-backtrace for more info)
> ||
> error[E0308]: mismatched types
> ||
> --> rust/kernel/lib.rs:234:45
> ||
> |
> ||
> 234 | $crate::assert_same_type(field_ptr, (&raw const (*container_ptr).
> $($fields)*).cast_mut());
> ||
> | ------------------------ ---------
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `*mut
> drm_gem_object`, found `*mut Opaque<drm_gem_object>`
> ||
> | | |
> ||
> | | expected all arguments to be this `*mut drm_gem_object` type because
> they need to match the type of this parameter
> ||
> | arguments to this function are incorrect
> ||
> |
> ||
> ::: rust/kernel/drm/gem/mod.rs:130:20
> ||
> |
> ||
> 130 | unsafe { &*crate::container_of!(self_ptr, Object<T>, obj) }
> ||
> | ---------------------------------------------- in this macro invocation
> ||
> |
> ||
> = note: expected raw pointer `*mut drm_gem_object`
> ||
> found raw pointer `*mut Opaque<drm_gem_object>`
> ||
> note: function defined here
> ||
> --> rust/kernel/lib.rs:241:8
> ||
> |
> ||
> 241 | pub fn assert_same_type<T>(_: T, _: T) {}
> ||
> | ^^^^^^^^^^^^^^^^ - ---- ---- this parameter needs to match the `*mut
> drm_gem_object` type of parameter #1
> ||
> | | |
> ||
> | | parameter #2 needs to match the `*mut drm_gem_object` type of this
> parameter
> ||
> | parameter #1 and parameter #2 both reference this parameter `T`
> ||
> = note: this error originates in the macro `crate::container_of` (in
> Nightly builds, run with -Z macro-backtrace for more info)
> ||
> error[E0308]: mismatched types
> ||
> --> rust/kernel/lib.rs:234:45
> ||
> |
> ||
> 234 | $crate::assert_same_type(field_ptr, (&raw const (*container_ptr).
> $($fields)*).cast_mut());
> ||
> | ------------------------ ---------
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `*mut
> drm_gem_object`, found `*mut Opaque<drm_gem_object>`
> ||
> | | |
> ||
> | | expected all arguments to be this `*mut drm_gem_object` type because
> they need to match the type of this parameter
> ||
> | arguments to this function are incorrect
> ||
> |
> ||
> ::: rust/kernel/drm/gem/mod.rs:273:29
> ||
> |
> ||
> 273 | let this = unsafe { crate::container_of!(obj, Self, obj) };
> ||
> | ------------------------------------ in this macro invocation
> ||
> |
> ||
> = note: expected raw pointer `*mut drm_gem_object`
> ||
> found raw pointer `*mut Opaque<drm_gem_object>`
> ||
> note: function defined here
> ||
> --> rust/kernel/lib.rs:241:8
> ||
> |
> ||
> 241 | pub fn assert_same_type<T>(_: T, _: T) {}
> ||
> | ^^^^^^^^^^^^^^^^ - ---- ---- this parameter needs to match the `*mut
> drm_gem_object` type of parameter #1
> ||
> | | |
> ||
> | | parameter #2 needs to match the `*mut drm_gem_object` type of this
> parameter
> ||
> | parameter #1 and parameter #2 both reference this parameter `T`
> ||
> = note: this error originates in the macro `crate::container_of` (in
> Nightly builds, run with -Z macro-backtrace for more info)
> ||
> error: aborting due to 3 previous errors
> ||
> For more information about this error, try `rustc --explain E0308`.
> ||
> make[2]: *** [rust/Makefile:538: rust/kernel.o] Error 1
> ||
> make[1]: *** [/home/pmos/build/src/linux-next-next-20250530/
> Makefile:1285: prepare] Error 2
> ||make: *** [Makefile:248: __sub-make] Error 2|
> 
> 
> Bad: next-20250530
> 
> Good: next-20250528
> 
> 
> Likely introduced with: https://lore.kernel.org/all/
> CANiq72mFiCrzawVUVOU2giJtBVsRdAO3sGtDsZptPuFvmid3EQ@mail.gmail.com/
> 
> 
> Repo: https://gitlab.postmarketos.org/LogicalErzor/pmaports/-/tree/rust/
> device/testing/linux-next
> 
> How it's built (Alpine-like build system):
> 
> - https://archive.ph/vxEmk
> 
> Config fragments (in addition to qcom_defconfig):
> 
> - https://archive.ph/q4hfc
> 
> - https://archive.ph/RKgFf
> 
> 
> 

Re: REGRESSION: armv7 build mismatched types

[Miguel Ojeda]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

On Fri, May 30, 2025 at 8:23 AM Rudraksha Gupta <guptarud@gmail.com> wrote:
>
> Bad: next-20250530
> Good: next-20250528

Thanks Rudraksha, the diff attached was needed on merge -- Stephen
didn't hit the error in his build so he didn't apply it just in case I
think, but it should be fixed in the next tag.

(If the diff doesn't work, of course, please let us know!)

Cheers,
Miguel

[-- Attachment #2: next-20250530.diff --]
[-- Type: application/x-patch, Size: 1858 bytes --]

Re: REGRESSION: armv7 build mismatched types

[Thorsten Leemhuis]

On 30.05.25 11:53, Miguel Ojeda wrote:
> On Fri, May 30, 2025 at 8:23 AM Rudraksha Gupta <guptarud@gmail.com> wrote:
>>
>> Bad: next-20250530
>> Good: next-20250528
> 
> Thanks Rudraksha, the diff attached was needed on merge -- Stephen
> didn't hit the error in his build so he didn't apply it just in case I
> think, but it should be fixed in the next tag.

Stephen, would be nice to see this picked up for -next, as I ran into
the error described at the start of the thread again with todays -next
on Fedora x86_64 and aarch64 using a Fedora rawhide config.

Or is this heading towards mainline really soon now anyway?

> (If the diff doesn't work, of course, please let us know!)

Thx, it fixed things for me.

Ciao, Thorsten

Re: REGRESSION: armv7 build mismatched types

[Miguel Ojeda]

On Tue, Jun 3, 2025 at 2:51 PM Thorsten Leemhuis <linux@leemhuis.info> wrote:
>
> Or is this heading towards mainline really soon now anyway?

The Rust PR is, but it would be nice to have the fix in -next before
sending the PR (I will give Linus a test merge anyway, but it is nice
to know everything is OK in -next too, and to have another reference
point for Linus).

> Thx, it fixed things for me.

Thanks for checking!

Cheers,
Miguel

Re: REGRESSION: armv7 build mismatched types

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

Hi Miguel,

On Tue, 3 Jun 2025 15:04:02 +0200 Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Tue, Jun 3, 2025 at 2:51 PM Thorsten Leemhuis <linux@leemhuis.info> wrote:
> >
> > Or is this heading towards mainline really soon now anyway?  
> 
> The Rust PR is, but it would be nice to have the fix in -next before
> sending the PR (I will give Linus a test merge anyway, but it is nice
> to know everything is OK in -next too, and to have another reference
> point for Linus).

Damn!  I knew I would forget.  Sorry about that, it will be applied
today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: REGRESSION: armv7 build mismatched types

[Miguel Ojeda]

On Tue, Jun 3, 2025 at 11:32 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Damn!  I knew I would forget.  Sorry about that, it will be applied
> today.

No worries! If you prefer that I send a reminder in this kind of
cases, I would be happy to do so.

Thanks!

Cheers,
Miguel

Re: REGRESSION: armv7 build mismatched types

[Miguel Ojeda]

On Tue, Jun 3, 2025 at 11:32 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Damn!  I knew I would forget.  Sorry about that, it will be applied
> today.

Looks good to me today, thanks!

Rudraksha/Thorsten: the error should be gone from your builds now.

Cheers,
Miguel

Re: REGRESSION: armv7 build mismatched types

[Rudraksha Gupta]

Perfect! Works for me now, thanks :)

Thanks,
Rudraksha