From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A85EC3A5E88 for ; Tue, 18 Nov 2025 17:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763485822; cv=none; b=gVJxtLhBZXGiZFHhx3eWPF2tlTJ++B5B75bM0CwONatEgGAEs6Pc8tXtSamU+2jhyRVWl4tCIIi/vmj5T0mkO40z4o7ypu9pPJDG7ii+RbJ89ZgBD5gj9SORX/MFM/KVFs0EPX4+289x/K7sJ4oTZ4nYOlmvBWGfPsBN+Lxg4Rg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763485822; c=relaxed/simple; bh=fslPMipxSHFdlEZigkiX4J0tsOkkEBsME1Uhhnj/iks=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=BJAccoyGW0hyjNdgGzwYHuIgn9bQpmA9INSuMYyI1tvWEPB7pAOMXibKJ33EpEpKOsNWR5fGFzFLPB4snhwrdn4wA9FJW3NpBsiBYUSiuS4BBNeQ9lxajEJlhsxsiH4FnOLL/xXXdmPckbs1UV/nmxIAEo9XPVyXmSWwrEzfNvM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iAXPsQbV; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iAXPsQbV" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-29806bd4776so7227025ad.0 for ; Tue, 18 Nov 2025 09:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763485820; x=1764090620; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fslPMipxSHFdlEZigkiX4J0tsOkkEBsME1Uhhnj/iks=; b=iAXPsQbV89zo7GjVESB4hHnnND/3he9CRsiyf/P6WPpoM0ltonatndiIzN08Y/ovUt 2zFERXxtvP7iP+Fridbxm2M7wiK2wdaw1jMnvl0juI6ix5MoLGoQF+oFZkdeQmcoqQbX u9axRbmLxcJSwLd4rBIPe/d2i8FrGh24KbqvKNDX/PtN7XdtijQG8zYYtnLFtru6agPm +VD8X5hamXj6ip6zyIwg9wHVGieQsVc54rU0RQTT53dpH1jRVeuQymEB/9Rfn6LO3dOg DHHbNZrVKKNjRwSzhIttcGlXpCEqPGRWJ42j6KdLsARPnfX4ZsqTnUr3C+P/6dKda8JR JywA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763485820; x=1764090620; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fslPMipxSHFdlEZigkiX4J0tsOkkEBsME1Uhhnj/iks=; b=KlwvfNZ/gXg4J6yhh3hwF278Xc+EzX4bBDuDoX30rRTObYBrtzRCuuyqrmtVJs+5Vu 4dRq9IBkID0+Xnd5sUFtp5JLWT3yji8PeN7G4uwWqiu6EWAAMlXCso0HmVjhLv80/HS6 WUTRVp0khI03EXij2dHmyAoupINZQFB64MLqUSFl4wzGi9mBcq8ojQiZdyWjbp8isBmv +f8T7ansg3jdmy4NCbok26u78qQdl54iS1z+K4tA5zcjwmWrK7ZyAxVBnY1XZihQM8wp a6eTRIj/fYHDOAGlpTJlCO6Rb0fgEqDeZZ3cLDKfqv1ymEM8wxZE9vSq8cGLcsEhwArx IW9A== X-Forwarded-Encrypted: i=1; AJvYcCUr3TyfYy97nhewBDFIBCY3ipS3l3UKdHOtZVAhrULlUHgN+fBhXEASPWvzaqPq0uHiY/htvbODGiVb1eij3w==@vger.kernel.org X-Gm-Message-State: AOJu0YxO2F03cIiz3sO6ClaGlqCR0p6dzfxgjhqs8NjhLUqzgIWVXgSe JJNxKEz9LCqHXsdy6GVisct48lDYwdO4XHbfcb7GPA/SdhLWcJSMcZFiDHW1FZX00NGM6EByKpW r3IQniqyhER5BYHyejVukrkd0VNByi0Q= X-Gm-Gg: ASbGncslvcoZeEdXzKc7/Rifa/0kwuX6CYB162kefxNstmcSbZdPixGQO/CX7u3gsdb Xuu5MJPV0gxeTRcLWOJQBGsUqODZmkKvOtLGSV9yuHeBNGAGnPfHIxcXTz1/gh8WgC4fNU/cyRa QWZUjG2/gz2ci6gqKm7ly/Xoulbbt4HjsNGtBqJM5EjPEUUbWMeGGwrHJCPBwx+9DxuYwu9WsHU OM/uymoMUJkEoJJYriBY1+2/mexImDzTajg40FnObXZVGhhIkdVhaasNWEYHFZxee892hqh6ofT /KKzX4nBJnTVz3QiAgzZRRD4Bg+Pn0JYDk0uSF/upatOtqwZ60vlKjgKxWH5La5aokF1ryBPAd2 zlW/aIEfhnjbSdQ== X-Google-Smtp-Source: AGHT+IG87WbBUsF3x/zF+o1Qu2UZcBiWl5amIiz3Lh5gRGa1HIv/hRj0ixT3na47lf+qzvGD/5GVRs4gchDNGH2A+EY= X-Received: by 2002:a05:693c:6017:b0:2a4:4862:c97a with SMTP id 5a478bee46e88-2a6c9899146mr825330eec.0.1763485819789; Tue, 18 Nov 2025 09:10:19 -0800 (PST) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251118072833.196876-3-phasta@kernel.org> <4db9dae5f659512146bd441cf2edf5a4aca16b93.camel@mailbox.org> In-Reply-To: From: Miguel Ojeda Date: Tue, 18 Nov 2025 18:10:07 +0100 X-Gm-Features: AWmQ_bmPc7Pdxa4HTqMeTreIcWd1c3f64ytsv1JIBsPJlKm0HOVfUtoJNp9n-KU Message-ID: Subject: Re: [PATCH v2] rust: list: Add unsafe for container_of To: phasta@kernel.org Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Tamir Duberstein , Christian Schrefl , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Nov 18, 2025 at 10:33=E2=80=AFAM Philipp Stanner wrote: > > It *is* absolutely common, or at least frequent, and you are the first > guy in the entire project I ever heard complaining about it. Maybe it > is often used wrongly or unnecessarily, though. > > But no worries, be assured that I will take this detail into account > when working with you. It is not, and since you seem to be keen on making an issue out of this, I took a quick look. What is actually common is using Cc: stable *without* constraints: ~84% of the cases in 2025. And that is *before* removing the cases where the constraint is actually ne= eded. > So why then do you even suggest running rustfmt? How should I make it > check the formatting? I didn't suggest running `rustfmt`. I asked to please double-check if that is the formatting that `rustfmt` *would* use, i.e. how those blocks are normally formatted elsewhere, precisely because the tool does not format it here. Now, it isn't nice to try to frame things as if the issue is with the other person (with remarks such as "first guy in the entire project" and "when working with you"). So I will help you no further. Cheers, Miguel