[PATCH] rust: add fast path to `RBTree::find_mut` for empty tree

[PATCH] rust: add fast path to `RBTree::find_mut` for empty tree

[Onur Özkan]

Adds a fast path to `RBTree::find_mut` that immediately returns `None`
when the tree is empty.

This should also benefit `RBTree::get_mut`, `RBTree::remove_node` and
`RBTree::remove` functions as they rely on `find_mut` internally.

Signed-off-by: Onur Özkan <work@onurozkan.dev>
---
 rust/kernel/rbtree.rs | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/rust/kernel/rbtree.rs b/rust/kernel/rbtree.rs
index 8d978c896747..a9b79b22ea32 100644
--- a/rust/kernel/rbtree.rs
+++ b/rust/kernel/rbtree.rs
@@ -365,6 +365,11 @@ pub fn entry(&mut self, key: K) -> Entry<'_, K, V> {

     /// Used for accessing the given node, if it exists.
     pub fn find_mut(&mut self, key: &K) -> Option<OccupiedEntry<'_, K, V>> {
+        // Fast path: return `None` when tree is empty.
+        if self.root.rb_node.is_null() {
+            return None;
+        }
+
         match self.raw_entry(key) {
             RawEntry::Occupied(entry) => Some(entry),
             RawEntry::Vacant(_entry) => None,
--
2.50.0

Re: [PATCH] rust: add fast path to `RBTree::find_mut` for empty tree

[Miguel Ojeda]

On Wed, Jun 25, 2025 at 3:52 PM Onur Özkan <work@onurozkan.dev> wrote:
>
> Oops, I didn't realize that `rb_node` was a pointer. Please don't take the patch seriously.  :)

I think this reply didn't reach the lists because it uses HTML.

Cheers,
Miguel