From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Jamie Cunliffe <Jamie.Cunliffe@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
steve.capper@arm.com, Asahi Lina <lina@asahilina.net>,
boqun.feng@gmail.com, Alice Ryhl <aliceryhl@google.com>,
Wedson Almeida Filho <wedsonaf@gmail.com>
Subject: Re: [PATCH v3 1/1] arm64: rust: Enable Rust support for AArch64
Date: Tue, 17 Oct 2023 17:38:28 +0200 [thread overview]
Message-ID: <CANiq72mXdYCbxHCKDRGh6SpzpnuAs-iPNwpXkpZf1mneRPBb+g@mail.gmail.com> (raw)
In-Reply-To: <20231016131523.1521965-2-Jamie.Cunliffe@arm.com>
On Mon, Oct 16, 2023 at 3:16 PM Jamie Cunliffe <Jamie.Cunliffe@arm.com> wrote:
>
> +KBUILD_RUSTFLAGS += --target aarch64-unknown-none -C target-feature="-neon"
For consistency with other flags we pass in Rust, please avoid the
space after `-C`.
By the way, perhaps we could already add others like (untested):
ifeq ($(CONFIG_ARM64_USE_LSE_ATOMICS),y)
+KBUILD_RUSTFLAGS += -Ctarget-feature="+lse"
ifneq ($(CONFIG_ARM64_LSE_ATOMICS),y)
@echo "warning: LSE atomics not supported by binutils" >&2
endif
This one in particular (LSE) came up in a Binder discussion yesterday.
Cheers,
Miguel
next prev parent reply other threads:[~2023-10-17 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 13:15 [PATCH v3 0/1] Rust enablement for AArch64 Jamie Cunliffe
2023-10-16 13:15 ` [PATCH v3 1/1] arm64: rust: Enable Rust support " Jamie Cunliffe
2023-10-16 18:14 ` Boqun Feng
2023-10-16 21:47 ` Andrew Lunn
2023-10-17 9:24 ` Miguel Ojeda
2023-10-17 9:27 ` Miguel Ojeda
2023-10-17 15:38 ` Miguel Ojeda [this message]
2023-10-17 17:47 ` Miguel Ojeda
2023-10-19 14:41 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72mXdYCbxHCKDRGh6SpzpnuAs-iPNwpXkpZf1mneRPBb+g@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=Jamie.Cunliffe@arm.com \
--cc=aliceryhl@google.com \
--cc=boqun.feng@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=lina@asahilina.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=steve.capper@arm.com \
--cc=wedsonaf@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).