* [PATCH] rust: rbtree: fix minor typos in comments
@ 2025-12-01 16:07 Atharv Dubey
2025-12-01 16:12 ` Miguel Ojeda
0 siblings, 1 reply; 3+ messages in thread
From: Atharv Dubey @ 2025-12-01 16:07 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Alex Gaynor, Boqun Feng, Gary Guo, Björn Roy Baron,
Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross,
Danilo Krummrich, Charalampos Mitrodimas, Yutaro Ohno,
Onur Özkan, Atharv Dubey, Borys Tyran, Daniel Sedlak,
Tamir Duberstein, rust-for-linux, linux-kernel
This patch corrects a few small grammatical errors in the
documentation comments to improve clarity and readability.
Link: https://github.com/Rust-for-Linux/linux/issues/1206
Signed-off-by: Atharv Dubey <atharvd440@gmail.com>
---
rust/kernel/rbtree.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/rust/kernel/rbtree.rs b/rust/kernel/rbtree.rs
index b8fe6be6fcc4..6c9708201fd7 100644
--- a/rust/kernel/rbtree.rs
+++ b/rust/kernel/rbtree.rs
@@ -732,7 +732,7 @@ pub struct Cursor<'a, K, V> {
}
// SAFETY: The [`Cursor`] has exclusive access to both `K` and `V`, so it is sufficient to require them to be `Send`.
-// The cursor only gives out immutable references to the keys, but since it has excusive access to those same
+// The cursor only gives out immutable references to the keys, but since it has exclusive access to those same
// keys, `Send` is sufficient. `Sync` would be okay, but it is more restrictive to the user.
unsafe impl<'a, K: Send, V: Send> Send for Cursor<'a, K, V> {}
@@ -980,7 +980,7 @@ pub struct IterMut<'a, K, V> {
}
// SAFETY: The [`IterMut`] has exclusive access to both `K` and `V`, so it is sufficient to require them to be `Send`.
-// The iterator only gives out immutable references to the keys, but since the iterator has excusive access to those same
+// The iterator only gives out immutable references to the keys, but since the iterator has exclusive access to those same
// keys, `Send` is sufficient. `Sync` would be okay, but it is more restrictive to the user.
unsafe impl<'a, K: Send, V: Send> Send for IterMut<'a, K, V> {}
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: rbtree: fix minor typos in comments
2025-12-01 16:07 [PATCH] rust: rbtree: fix minor typos in comments Atharv Dubey
@ 2025-12-01 16:12 ` Miguel Ojeda
2025-12-01 16:41 ` Atharv Dubey
0 siblings, 1 reply; 3+ messages in thread
From: Miguel Ojeda @ 2025-12-01 16:12 UTC (permalink / raw)
To: Atharv Dubey
Cc: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, Danilo Krummrich, Charalampos Mitrodimas,
Yutaro Ohno, Onur Özkan, Borys Tyran, Daniel Sedlak,
Tamir Duberstein, rust-for-linux, linux-kernel
On Mon, Dec 1, 2025 at 5:07 PM Atharv Dubey <atharvd440@gmail.com> wrote:
>
> This patch corrects a few small grammatical errors in the
s/few/couple?
It is also not a grammatical error, no? i.e. it is just a typo within a word.
> Link: https://github.com/Rust-for-Linux/linux/issues/1206
Thanks for doing these; however, since you already did other "good
first issues", please do not do more to let others pick them up :)
It is why I typically write "...to use it as a test to submit your
first patch to the kernel." in the issue text.
We can take this one since you did it already anyway. Please add the
Suggested-by tag as well.
Thanks!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: rbtree: fix minor typos in comments
2025-12-01 16:12 ` Miguel Ojeda
@ 2025-12-01 16:41 ` Atharv Dubey
0 siblings, 0 replies; 3+ messages in thread
From: Atharv Dubey @ 2025-12-01 16:41 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, Danilo Krummrich, Charalampos Mitrodimas,
Yutaro Ohno, Onur Özkan, Borys Tyran, Daniel Sedlak,
Tamir Duberstein, rust-for-linux, linux-kernel
On Mon, Dec 01, 2025 at 05:12:33PM +0100, Miguel Ojeda wrote:
> On Mon, Dec 1, 2025 at 5:07 PM Atharv Dubey <atharvd440@gmail.com> wrote:
> >
> > This patch corrects a few small grammatical errors in the
>
> s/few/couple?
>
> It is also not a grammatical error, no? i.e. it is just a typo within a word.
> Thanks for the feedback !, I'll update the commit message according to
> your suggestion.
> > Link: https://github.com/Rust-for-Linux/linux/issues/1206
>
> Thanks for doing these; however, since you already did other "good
> first issues", please do not do more to let others pick them up :)
>
> It is why I typically write "...to use it as a test to submit your
> first patch to the kernel." in the issue text.
>
> We can take this one since you did it already anyway. Please add the
> Suggested-by tag as well.
> Got it, will keep this in mind for future contributions.
> Thanks!
>
> Cheers,
> Miguel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-01 16:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-01 16:07 [PATCH] rust: rbtree: fix minor typos in comments Atharv Dubey
2025-12-01 16:12 ` Miguel Ojeda
2025-12-01 16:41 ` Atharv Dubey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).