rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: "Hsiu Che Yu" <yu.whisper.personal@gmail.com>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Yury Norov" <yury.norov@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>
Subject: Re: [PATCH v2] rust: num: bounded: mark __new as unsafe
Date: Wed, 3 Dec 2025 15:23:02 +0100	[thread overview]
Message-ID: <CANiq72mq5TCa4NqpxOMq3-e55N8Z4757Zx_=uzVge2QfqXOprA@mail.gmail.com> (raw)
In-Reply-To: <DEOKZ255N1YJ.1U9OX5KDWQGY2@nvidia.com>

On Wed, Dec 3, 2025 at 1:29 PM Alexandre Courbot <acourbot@nvidia.com> wrote:
>
> Wasn't it Alice who said that `__new` should be unsafe?

The issue was about making it unsafe -- I added the "Otherwise" branch
to make it a bit more "open", i.e. sometimes I try to make those "good
first issues" in a way that it is not completely automated, e.g. here
so that the new contributor has to think what it means for a function
to be unsafe or not, rather than just converting it. Given Hsiu's
reply in v1, it seems it worked! :)

Cheers,
Miguel

      reply	other threads:[~2025-12-03 14:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-02  3:25 [PATCH v2] rust: num: bounded: mark __new as unsafe Hsiu Che Yu
2025-12-03 12:29 ` Alexandre Courbot
2025-12-03 14:23   ` Miguel Ojeda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANiq72mq5TCa4NqpxOMq3-e55N8Z4757Zx_=uzVge2QfqXOprA@mail.gmail.com' \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=yu.whisper.personal@gmail.com \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).