rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Burak Emir <bqe@google.com>, Kaibo Ma <ent3rm4n@gmail.com>
Cc: "Yury Norov" <yury.norov@gmail.com>,
	"Kees Cook" <kees@kernel.org>,
	"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Gustavo A . R . Silva" <gustavoars@kernel.org>,
	"Carlos LLama" <cmllamas@google.com>,
	"Pekka Ristola" <pekkarr@protonmail.com>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH v16 3/5] rust: add bitmap API.
Date: Mon, 8 Sep 2025 11:33:24 +0200	[thread overview]
Message-ID: <CANiq72msV_jLFDtA4LUk01W6WF_hJEivdeKyR14xmA6ocYx3RQ@mail.gmail.com> (raw)
In-Reply-To: <20250908072158.1041611-4-bqe@google.com>

On Mon, Sep 8, 2025 at 9:22 AM Burak Emir <bqe@google.com> wrote:
>
> +    #[test]
> +    fn owned_bitmap_out_of_bounds() -> Result<(), AllocError> {
> +        // TODO: Kunit #[test]s do not support `cfg` yet,
> +        // so we add it here in the body.
> +        #[cfg(not(CONFIG_RUST_BITMAP_HARDENED))]
> +        {
> +            let mut b = BitmapVec::new(128, GFP_KERNEL)?;
> +            b.set_bit(2048);
> +            b.set_bit_atomic(2048);
> +            b.clear_bit(2048);
> +            b.clear_bit_atomic(2048);
> +            assert_eq!(None, b.next_bit(2048));
> +            assert_eq!(None, b.next_zero_bit(2048));
> +            assert_eq!(None, b.last_bit());
> +        }
> +        Ok(())
> +    }

For context, Kaibo Ma already posted a patch to solve that limitation,
so we should be able to clean this up e.g. next cycle:

https://lore.kernel.org/rust-for-linux/20250907201558.104566-2-ent3rm4n@gmail.com/

Cheers,
Miguel

  reply	other threads:[~2025-09-08  9:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08  7:21 [PATCH v16 0/5] rust: adds Bitmap API, ID pool and bindings Burak Emir
2025-09-08  7:21 ` [PATCH v16 1/5] rust: add bindings for bitmap.h Burak Emir
2025-09-08  7:21 ` [PATCH v16 2/5] rust: add bindings for bitops.h Burak Emir
2025-09-08  7:21 ` [PATCH v16 3/5] rust: add bitmap API Burak Emir
2025-09-08  9:33   ` Miguel Ojeda [this message]
2025-09-08  7:21 ` [PATCH v16 4/5] rust: add find_bit_benchmark_rust module Burak Emir
2025-09-08  7:21 ` [PATCH v16 5/5] rust: add dynamic ID pool abstraction for bitmap Burak Emir
2025-09-09 17:14 ` [PATCH v16 0/5] rust: adds Bitmap API, ID pool and bindings Yury Norov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANiq72msV_jLFDtA4LUk01W6WF_hJEivdeKyR14xmA6ocYx3RQ@mail.gmail.com \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=bqe@google.com \
    --cc=cmllamas@google.com \
    --cc=ent3rm4n@gmail.com \
    --cc=gary@garyguo.net \
    --cc=gustavoars@kernel.org \
    --cc=kees@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=ojeda@kernel.org \
    --cc=pekkarr@protonmail.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=viresh.kumar@linaro.org \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).