From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Onur <work@onurozkan.dev>
Cc: viresh.kumar@linaro.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
airlied@gmail.com, simona@ffwll.ch, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
rafael@kernel.org, gregkh@linuxfoundation.org,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, davidgow@google.com, nm@ti.com
Subject: Re: [PATCH v3 3/3] rust: remove `#[allow(clippy::non_send_fields_in_send_ty)]`
Date: Sat, 28 Jun 2025 14:51:15 +0200 [thread overview]
Message-ID: <CANiq72mxJM-7WAP8xVDukmiXq=ntThyFESFLs1+dmZJSS2q60Q@mail.gmail.com> (raw)
In-Reply-To: <20250628154237.0f367cee@nimda.home>
On Sat, Jun 28, 2025 at 2:42 PM Onur <work@onurozkan.dev> wrote:
>
> Yes, I am sure. Just to clarify, I am not testing 5e7c9b84ad08. I am
> testing c6af9a1191d042839e56abff69e8b0302d117988 where
> `#[allow(clippy::non_send_fields_in_send_ty)]` was added on
> `unsafe impl<T: Driver> Send for Registration<T> {}`.
>
> Switching from `allow` to `expect` produced the following result on my
> end:
Yes, of course it does -- what I am telling you (and what 5e7c9b84ad08
says) is that the lint is disabled.
And since it is disabled, if you change the line to `expect`, then it
will obviously complain.
If you actually enabled the lint with e.g.
#![warn(clippy::non_send_fields_in_send_ty)]
at the top of the file, and then used `expect`, it will build fine.
Cheers,
Miguel
next prev parent reply other threads:[~2025-06-28 12:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 4:09 [PATCH v3 0/3] replace `allow(...)` lints with `expect(...)` Onur Özkan
2025-06-28 4:09 ` [PATCH v3 1/3] replace `#[allow(...)]` with `#[expect(...)]` Onur Özkan
2025-06-29 7:43 ` kernel test robot
2025-06-28 4:09 ` [PATCH v3 2/3] rust: remove `#[allow(clippy::unnecessary_cast)]` Onur Özkan
2025-06-28 4:09 ` [PATCH v3 3/3] rust: remove `#[allow(clippy::non_send_fields_in_send_ty)]` Onur Özkan
2025-06-28 7:13 ` Miguel Ojeda
2025-06-28 10:30 ` Onur
2025-06-28 12:18 ` Miguel Ojeda
2025-06-28 12:42 ` Onur
2025-06-28 12:51 ` Miguel Ojeda [this message]
2025-06-28 13:11 ` Onur
2025-06-28 13:28 ` Miguel Ojeda
2025-06-28 13:42 ` Onur
2025-06-28 14:14 ` Miguel Ojeda
2025-06-28 12:48 ` Onur
2025-06-28 13:37 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72mxJM-7WAP8xVDukmiXq=ntThyFESFLs1+dmZJSS2q60Q@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=davidgow@google.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nm@ti.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=tzimmermann@suse.de \
--cc=viresh.kumar@linaro.org \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).