From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Haiyue Wang <haiyuewa@163.com>,
rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
linux-modules@vger.kernel.org,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: Only rust/bindings.o build fail on rust-1.91.0
Date: Tue, 11 Nov 2025 22:41:18 +0100 [thread overview]
Message-ID: <CANiq72n09yx9ZjOtOb3-3rPfpPLKaJZ2fs_Bmpbz28Y8U05snA@mail.gmail.com> (raw)
In-Reply-To: <CANiq72mLbEVqX-uBtqy+_wru9CRRb3PL3qFqYEcjpZdNyZGd2w@mail.gmail.com>
On Sat, Nov 8, 2025 at 6:08 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> Exactly, that is what I was suggesting in the other thread about
> editing the `cmd` command or directly teaching `genkallksyms` to
> auto-skip, but I didn't know if there was a reason you didn't do that
> originally instead of having (some of) the `skip_*` lines in the
> `Makefile`.
>
> If not, then I assume we could already remove some of those lines,
> e.g. the one for `ffi.o` (no need to do it on the fix, of course,
> better to keep it minimal, but just to confirm there is no hidden
> reason there).
For (cross-)reference: I sent "v2" of the fix, essentially taking your
patch and my commit log and putting them together -- please let me
know if this is with you!
https://lore.kernel.org/rust-for-linux/20251110131913.1789896-1-ojeda@kernel.org/
Thanks!
Cheers,
Miguel
next prev parent reply other threads:[~2025-11-11 21:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 13:08 Only rust/bindings.o build fail on rust-1.91.0 Haiyue Wang
2025-11-06 13:57 ` Miguel Ojeda
2025-11-06 14:04 ` Haiyue Wang
2025-11-06 16:07 ` Sami Tolvanen
2025-11-06 17:54 ` Miguel Ojeda
2025-11-08 1:41 ` Miguel Ojeda
2025-11-08 2:39 ` Sami Tolvanen
2025-11-08 3:51 ` Miguel Ojeda
2025-11-08 4:04 ` Miguel Ojeda
2025-11-08 4:42 ` Sami Tolvanen
2025-11-08 5:08 ` Miguel Ojeda
2025-11-11 21:41 ` Miguel Ojeda [this message]
2025-11-11 21:52 ` Sami Tolvanen
2025-11-08 5:10 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72n09yx9ZjOtOb3-3rPfpPLKaJZ2fs_Bmpbz28Y8U05snA@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=haiyuewa@163.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).