[PATCH net v3] net: phy: qt2025: Fix warning: unused import DeviceId

[PATCH net v3] net: phy: qt2025: Fix warning: unused import DeviceId

[FUJITA Tomonori]

Fix the following warning when the driver is compiled as built-in:

      warning: unused import: `DeviceId`
      --> drivers/net/phy/qt2025.rs:18:5
      |
   18 |     DeviceId, Driver,
      |     ^^^^^^^^
      |
      = note: `#[warn(unused_imports)]` on by default

device_table in module_phy_driver macro is defined only when the
driver is built as a module. Use phy::DeviceId in the macro instead of
importing `DeviceId` since `phy` is always used.

Fixes: fd3eaad826da ("net: phy: add Applied Micro QT2025 PHY driver")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202409190717.i135rfVo-lkp@intel.com/
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Trevor Gross <tmgross@umich.edu>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
---
v3:
 - add Fixes tag
v2:
 - fix the commit log
 - add Alice and Trevor's Reviewed-by
---
 drivers/net/phy/qt2025.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs
index 28d8981f410b..1ab065798175 100644
--- a/drivers/net/phy/qt2025.rs
+++ b/drivers/net/phy/qt2025.rs
@@ -15,7 +15,7 @@
 use kernel::net::phy::{
     self,
     reg::{Mmd, C45},
-    DeviceId, Driver,
+    Driver,
 };
 use kernel::prelude::*;
 use kernel::sizes::{SZ_16K, SZ_8K};
@@ -23,7 +23,7 @@
 kernel::module_phy_driver! {
     drivers: [PhyQT2025],
     device_table: [
-        DeviceId::new_with_driver::<PhyQT2025>(),
+        phy::DeviceId::new_with_driver::<PhyQT2025>(),
     ],
     name: "qt2025_phy",
     author: "FUJITA Tomonori <fujita.tomonori@gmail.com>",

base-commit: 72ef07554c5dcabb0053a147c4fd221a8e39bcfd
-- 
2.34.1

Re: [PATCH net v3] net: phy: qt2025: Fix warning: unused import DeviceId

[Fiona Behrens]

On 26 Sep 2024, at 14:14, FUJITA Tomonori wrote:

> Fix the following warning when the driver is compiled as built-in:
>
>       warning: unused import: `DeviceId`
>       --> drivers/net/phy/qt2025.rs:18:5
>       |
>    18 |     DeviceId, Driver,
>       |     ^^^^^^^^
>       |
>       = note: `#[warn(unused_imports)]` on by default
>
> device_table in module_phy_driver macro is defined only when the
> driver is built as a module. Use phy::DeviceId in the macro instead of
> importing `DeviceId` since `phy` is always used.
>
> Fixes: fd3eaad826da ("net: phy: add Applied Micro QT2025 PHY driver")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202409190717.i135rfVo-lkp@intel.com/
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> Reviewed-by: Trevor Gross <tmgross@umich.edu>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
> ---

Reviewed-by: Fiona Behrens <me@kloenk.dev>

Re: [PATCH net v3] net: phy: qt2025: Fix warning: unused import DeviceId

[Miguel Ojeda]

On Thu, Sep 26, 2024 at 2:16 PM FUJITA Tomonori
<fujita.tomonori@gmail.com> wrote:
>
> Fix the following warning when the driver is compiled as built-in:

Do you mind if I pick this up so that we keep WERROR builds
error-free? (I am sending a `rust-fixes` PR in a day or two to Linus).

Or is netdev going to pick it soon? If so:

Acked-by: Miguel Ojeda <ojeda@kernel.org>

Thanks!

Cheers,
Miguel

Re: [PATCH net v3] net: phy: qt2025: Fix warning: unused import DeviceId

[Andrew Lunn]

On Tue, Oct 01, 2024 at 05:52:48PM +0200, Miguel Ojeda wrote:
> On Thu, Sep 26, 2024 at 2:16 PM FUJITA Tomonori
> <fujita.tomonori@gmail.com> wrote:
> >
> > Fix the following warning when the driver is compiled as built-in:
> 
> Do you mind if I pick this up so that we keep WERROR builds
> error-free? (I am sending a `rust-fixes` PR in a day or two to Linus).
> 
> Or is netdev going to pick it soon? If so:

It was marked for stable, so generally means it will get submitted to
Linus in a PR on Thursdays.

      Andrew

Re: [PATCH net v3] net: phy: qt2025: Fix warning: unused import DeviceId

[Miguel Ojeda]

On Tue, Oct 1, 2024 at 6:36 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> It was marked for stable, so generally means it will get submitted to
> Linus in a PR on Thursdays.

Thanks Andrew, that sounds perfect.

Cheers,
Miguel

Re: [PATCH net v3] net: phy: qt2025: Fix warning: unused import DeviceId

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 26 Sep 2024 12:14:03 +0000 you wrote:
> Fix the following warning when the driver is compiled as built-in:
> 
>       warning: unused import: `DeviceId`
>       --> drivers/net/phy/qt2025.rs:18:5
>       |
>    18 |     DeviceId, Driver,
>       |     ^^^^^^^^
>       |
>       = note: `#[warn(unused_imports)]` on by default
> 
> [...]

Here is the summary with links:
  - [net,v3] net: phy: qt2025: Fix warning: unused import DeviceId
    https://git.kernel.org/netdev/net/c/fa7dfeae041c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html