From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Dirk Behme <dirk.behme@gmail.com>
Cc: "Tamir Duberstein" <tamird@gmail.com>,
rust-for-linux@vger.kernel.org, "Gary Guo" <gary@garyguo.net>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Dirk Behme" <dirk.behme@de.bosch.com>,
"Filipe Xavier" <felipe_life@live.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: remove unnecessary #includes
Date: Wed, 9 Oct 2024 17:58:31 +0200 [thread overview]
Message-ID: <CANiq72nUT6cFXCGg4jfN07W7UE-8vma=o9a5DQjsRwtNsKUGbQ@mail.gmail.com> (raw)
In-Reply-To: <813594ff-b167-4ae2-8105-e2f958ec2cc7@gmail.com>
On Wed, Oct 9, 2024 at 5:37 PM Dirk Behme <dirk.behme@gmail.com> wrote:
>
> * Theoretically the grammer fix in exports.c could go into an
> independent patch. But if not it at least should be mentioned in the
> commit message. Let Miguel decide if he wants an extra patch or not ;)
Indeed, in general, one should not have unstated/unrelated changes.
> * Maybe a
>
> Fixes: e26fa546042a ("rust: kbuild: auto generate helper exports")
>
> tag could be added? Even though Miguel might route it through
> rust-next as its not urgent for routing through rust-fixes.
I think this is a cleanup, i.e. just unnecessary `#include`s being
present, right? In other words, there is no "bug" apart from not being
optimal (one could see cleanups as things that should have been done,
but I guess we should draw the line somewhere).
Andreas: was there a reason to keep those `#include`s, just in case?
Thanks!
Cheers,
Miguel
next prev parent reply other threads:[~2024-10-09 15:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 15:09 [PATCH] rust: remove unnecessary #includes Tamir Duberstein
2024-10-09 15:37 ` Dirk Behme
2024-10-09 15:58 ` Miguel Ojeda [this message]
2024-10-09 16:12 ` Tamir Duberstein
2024-10-09 16:17 ` Miguel Ojeda
2024-10-09 16:25 ` [PATCH v2] rust: remove unnecessary header includes Tamir Duberstein
2024-10-10 9:17 ` Andreas Hindborg
2024-10-12 18:43 ` Gary Guo
2024-10-21 18:12 ` Miguel Ojeda
2024-10-10 9:10 ` [PATCH] rust: remove unnecessary #includes Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72nUT6cFXCGg4jfN07W7UE-8vma=o9a5DQjsRwtNsKUGbQ@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dirk.behme@de.bosch.com \
--cc=dirk.behme@gmail.com \
--cc=felipe_life@live.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).