From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Alexander Pantyukhin <apantykhin@gmail.com>
Cc: ojeda@kernel.org, rust-for-linux@vger.kernel.org,
akpm@linux-foundation.org, Asahi Lina <lina@asahilina.net>
Subject: Re: [PATCH] scripts: avoid redundant re-reading makefiles.
Date: Fri, 6 Jan 2023 00:01:23 +0100 [thread overview]
Message-ID: <CANiq72nUdX2vziY036OfNEzGi3W+q9D+yyBpm81-0sNjNg-gqw@mail.gmail.com> (raw)
In-Reply-To: <CAPi66w-2aV8CQs6xGSR4xZn4+39HdUqvwTZEidYKqUR-11thDA@mail.gmail.com>
On Thu, Jan 5, 2023 at 8:51 PM Alexander Pantyukhin
<apantykhin@gmail.com> wrote:
>
> I checked files now. It seems only one place in /samples has 2 files
> with 1 makefile in the parent folder. So it looks like the patch is
> untimely for now.
Yeah, though you could do a benchmark with more files to account for
the future :)
> I see, thanks. Still have a question about using "with". Is it reasonable?
It is definitely reasonable and you cannot go wrong with `with`. I am
not sure if matters much in this case (short-lived script, read-only,
not a huge amount of files...), and with CPython the objects are
destroyed immediately anyway I believe.
Cheers,
Miguel
prev parent reply other threads:[~2023-01-05 23:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 16:04 [PATCH] scripts: avoid redundant re-reading makefiles Alexander Pantyukhin
2023-01-05 18:44 ` Miguel Ojeda
2023-01-05 19:51 ` Alexander Pantyukhin
2023-01-05 23:01 ` Miguel Ojeda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72nUdX2vziY036OfNEzGi3W+q9D+yyBpm81-0sNjNg-gqw@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apantykhin@gmail.com \
--cc=lina@asahilina.net \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).