From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Gary Guo <gary@garyguo.net>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust: macros: add `paste!` proc macro
Date: Thu, 10 Aug 2023 00:29:06 +0200 [thread overview]
Message-ID: <CANiq72nWArGsvWVVknPdAVYUbWqJKfwOAVCRUmLnuAHAHP+rSQ@mail.gmail.com> (raw)
In-Reply-To: <20230809230249.01ffc009.gary@garyguo.net>
On Thu, Aug 10, 2023 at 12:02 AM Gary Guo <gary@garyguo.net> wrote:
>
> Sorry I forgot to add license comments!
No problem at all :)
> All my kernel contributions are permissively licensed if possible, so I
> am fine with this being either MIT or GPL-2.0 (I think GPL-2.0 is
> deprecated in as a SPDX license identifier and it should be
> GPL-2.0-only going forward, though).
Yeah, the 3.0 version of the SPDX license list deprecated `GPL-2.0`,
but the kernel still allows `GPL-2.0` and lists it first. I recall
thinking about this before the initial merge, and I think I went with
the original form because the main `COPYING` file still uses that.
After that I am just keeping it consistent, though I am not sure when
the kernel will migrate.
> Given this is non-kernel specific generic code, I think it might worth
> following the convention of the paste and pin-init code and make it
> `Apache-2.0 OR MIT`? This would also make it the same license as the
> `paste` crate (although we don't have to keep the same license as this
> is a different implementation).
>
> I'll leave the final decision to you.
Since you prefer it and it makes sense that someone may want to use it
(`concat` and `expand`) elsewhere, let's go with that. I will add:
// SPDX-License-Identifier: Apache-2.0 OR MIT
then. Thanks for the very quick reply!
Cheers,
Miguel
next prev parent reply other threads:[~2023-08-09 22:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 17:11 [PATCH] rust: macros: add `paste!` proc macro Gary Guo
2023-06-28 19:00 ` Benno Lossin
2023-06-28 19:03 ` Björn Roy Baron
2023-06-29 0:51 ` Martin Rodriguez Reboredo
2023-07-03 11:37 ` Alice Ryhl
2023-08-09 21:45 ` Miguel Ojeda
2023-08-09 22:02 ` Gary Guo
2023-08-09 22:29 ` Miguel Ojeda [this message]
2023-08-10 5:08 ` Greg KH
2023-08-10 7:56 ` Miguel Ojeda
2023-08-10 15:46 ` Greg KH
2023-08-10 20:32 ` Miguel Ojeda
2023-08-09 23:22 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72nWArGsvWVVknPdAVYUbWqJKfwOAVCRUmLnuAHAHP+rSQ@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).