From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Benno Lossin <benno.lossin@proton.me>
Cc: "Gary Guo" <gary@garyguo.net>,
"Matt Gilbride" <mattgilbride@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Carlos Llamas" <cmllamas@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Christian Brauner" <brauner@kernel.org>,
"Rob Landley" <rob@landley.net>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"Michel Lespinasse" <michel@lespinasse.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/6] rust: kernel: add `drop_contents` to `BoxExt`
Date: Sat, 3 Aug 2024 14:24:21 +0200 [thread overview]
Message-ID: <CANiq72n_v76yMFJwy8S+Akf6T8hOM-JGwP_WUKEdiNvo371NfQ@mail.gmail.com> (raw)
In-Reply-To: <52cc1987-ec62-46dd-9d81-4afc155fe88f@proton.me>
On Wed, Jul 31, 2024 at 10:47 PM Benno Lossin <benno.lossin@proton.me> wrote:
>
> Note that the newest version of this patch can be found at [1]. I agree,
> it should probably take `this: Self` instead of a `self` receiver.
>
> @Miguel, do you think I should send a new version with that change?
You mean with `this` + Boqun's feedback there fixed? Yeah, if you have
a moment, that would be nice. Thanks!
Cheers,
Miguel
next prev parent reply other threads:[~2024-08-03 12:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 16:20 [PATCH v6 0/6] Red-black tree abstraction needed by Rust Binder Matt Gilbride
2024-07-11 16:20 ` [PATCH v6 1/6] rust: kernel: add `drop_contents` to `BoxExt` Matt Gilbride
2024-07-23 9:15 ` Alice Ryhl
2024-07-31 20:02 ` Gary Guo
2024-07-31 20:47 ` Benno Lossin
2024-08-03 12:24 ` Miguel Ojeda [this message]
2024-07-11 16:20 ` [PATCH v6 2/6] rust: rbtree: add red-black tree implementation backed by the C version Matt Gilbride
2024-07-11 16:20 ` [PATCH v6 3/6] rust: rbtree: add iterator Matt Gilbride
2024-07-11 16:21 ` [PATCH v6 4/6] rust: rbtree: add mutable iterator Matt Gilbride
2024-07-11 16:21 ` [PATCH v6 5/6] rust: rbtree: add `RBTreeCursor` Matt Gilbride
2024-07-11 16:21 ` [PATCH v6 6/6] rust: rbtree: add `RBTree::entry` Matt Gilbride
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72n_v76yMFJwy8S+Akf6T8hOM-JGwP_WUKEdiNvo371NfQ@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=arve@android.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=dave@stgolabs.net \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=mattgilbride@google.com \
--cc=michel@lespinasse.org \
--cc=ojeda@kernel.org \
--cc=rob@landley.net \
--cc=rust-for-linux@vger.kernel.org \
--cc=surenb@google.com \
--cc=tkjos@android.com \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).