From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Asuna Yang <spriteovo@gmail.com>
Cc: "Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nicolas.schier@linux.dev>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Nicolas Schier" <nsc@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Vivian Wang" <wangruikang@iscas.ac.cn>,
"Han Gao" <rabenda.cn@gmail.com>,
"Jason Montleon" <jmontleo@redhat.com>,
"Conor Dooley" <conor@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org, llvm@lists.linux.dev,
linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 4/4] RISC-V: fix gcc + rust builds
Date: Mon, 24 Nov 2025 02:21:08 +0100 [thread overview]
Message-ID: <CANiq72nqzPiiefC6Q9C0_rzoS8saL_EJ5qiTpMhZtG8pAsmmUw@mail.gmail.com> (raw)
In-Reply-To: <20251124-gcc-rust-v4-v4-4-4e06e07421ae@gmail.com>
On Mon, Nov 24, 2025 at 1:23 AM Asuna Yang <spriteovo@gmail.com> wrote:
>
> Commit 33549fcf37ec ("RISC-V: disallow gcc + rust builds") disabled GCC
> + Rust builds for RISC-V due to differences in extension handling
> compared to LLVM.
This should mention what we are doing, i.e. re-enabling the GCC + Rust
support again.
Also, I would recommend avoiding to say "fix" in the title, unless it
is actually a fix, but perhaps the RISC-V maintainers consider it a
fix.
> Add `rust-bindgen-option` conditions for the availability of libclang to
> the RISC-V extension Kconfig symbols that depend on the `cc-option`
> function.
This is now in a different commit, right?
> Update the documentation, GCC + Rust builds for RISC-V are now
> supported.
"are now maintained" may be better to avoid confusing it with the
"Level of Support" in the table.
> Documentation/rust/arch-support.rst | 2 +-
> rust/Makefile | 3 ++-
> scripts/Makefile.rust | 1 +
In any case, for the Rust bits, this seems OK (I didn't test it, though), so:
Acked-by: Miguel Ojeda <ojeda@kernel.org>
(By the way, I wouldn't mind if we started adding `MAINTAINERS`
entries on who is maintaining particular architectures for Rust,
especially if there is someone in particular involved with it etc.).
Thanks!
Cheers,
Miguel
next prev parent reply other threads:[~2025-11-24 1:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 0:23 [PATCH v4 0/4] RISC-V: re-enable gcc + rust builds Asuna Yang
2025-11-24 0:23 ` [PATCH v4 1/4] rust: export BINDGEN_TARGET from a separate Makefile Asuna Yang
2025-11-24 1:40 ` Miguel Ojeda
2025-11-24 0:23 ` [PATCH v4 2/4] rust: generate a fatal error if BINDGEN_TARGET is undefined Asuna Yang
2025-11-24 1:24 ` Miguel Ojeda
2025-11-24 0:23 ` [PATCH v4 3/4] rust: add a Kconfig function to test for support of bindgen options Asuna Yang
2025-11-24 1:48 ` Miguel Ojeda
2025-11-24 2:42 ` Asuna Yang
2025-11-24 3:08 ` Miguel Ojeda
2025-11-24 18:36 ` Nathan Chancellor
2025-11-24 0:23 ` [PATCH v4 4/4] RISC-V: fix gcc + rust builds Asuna Yang
2025-11-24 1:21 ` Miguel Ojeda [this message]
2025-11-24 2:05 ` Asuna Yang
2025-11-24 2:12 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72nqzPiiefC6Q9C0_rzoS8saL_EJ5qiTpMhZtG8pAsmmUw@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=alex@ghiti.fr \
--cc=aliceryhl@google.com \
--cc=aou@eecs.berkeley.edu \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=jmontleo@redhat.com \
--cc=justinstitt@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=lossin@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nicolas.schier@linux.dev \
--cc=nsc@kernel.org \
--cc=ojeda@kernel.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=rabenda.cn@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=spriteovo@gmail.com \
--cc=tmgross@umich.edu \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).