From: "Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>
To: "Andrea Righi" <andrea.righi@canonical.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
<rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rust: fix regexp in scripts/is_rust_module.sh
Date: Sat, 11 Feb 2023 10:25:15 +0100 [thread overview]
Message-ID: <CQFMIYLWW6ZO.3LCN13CG142KC@vincent-arch> (raw)
In-Reply-To: <20230210152622.92912-1-andrea.righi@canonical.com>
> nm can use "R" or "r" to show read-only data sections, but
> scripts/is_rust_module.sh can only recognize "r", so with some versions
> of binutils it can fail to detect if a module is a Rust module or not.
>
> Right now we're using this script only to determine if we need to skip
> BTF generation (that is disabled globally if CONFIG_RUST is enabled),
> but it's still nice to fix this script to do the proper job.
>
> Moreover, with this patch applied I can also relax the constraint of
> "RUST depends on !DEBUG_INFO_BTF" and build a kernel with Rust and BTF
> enabled at the same time (of course BTF generation is still skipped for
> Rust modules).
>
> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
next prev parent reply other threads:[~2023-02-11 9:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 15:26 [PATCH] rust: fix regexp in scripts/is_rust_module.sh Andrea Righi
2023-02-11 9:25 ` Vincenzo Palazzo [this message]
2023-02-13 13:19 ` Miguel Ojeda
2023-02-13 14:27 ` Eric Curtin
2023-02-13 15:01 ` Andrea Righi
2023-02-13 15:45 ` Miguel Ojeda
2023-02-13 14:56 ` Martin Rodriguez Reboredo
2023-04-06 22:56 ` Miguel Ojeda
[not found] <'CANiq72=FZtNmYvbb-YPHmQ=bm8rH8VO3M9nemT4i03g9A2PD2Q@mail.gmail.com'>
2023-02-13 15:13 ` Martin Rodriguez Reboredo
2023-02-13 15:48 ` Andrea Righi
2023-02-13 16:03 ` Eric Curtin
2023-02-13 17:43 ` Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CQFMIYLWW6ZO.3LCN13CG142KC@vincent-arch \
--to=vincenzopalazzodev@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=andrea.righi@canonical.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).