Re: [RFC PATCH v1 1/4] rust: core abstractions for network PHY drivers

["Jarkko Sakkinen" <jarkko@kernel.org>]

On Thu Sep 14, 2023 at 8:47 AM EEST, Trevor Gross wrote:
> > +/// Corresponds to the kernel's `enum phy_state`.
> > +#[derive(PartialEq)]
> > +pub enum DeviceState {
> > +    /// PHY device and driver are not ready for anything.
> > +    Down,
> > +    /// PHY is ready to send and receive packets.
> > +    Ready,
> > +    /// PHY is up, but no polling or interrupts are done.
> > +    Halted,
> > +    /// PHY is up, but is in an error state.
> > +    Error,
> > +    /// PHY and attached device are ready to do work.
> > +    Up,
> > +    /// PHY is currently running.
> > +    Running,
> > +    /// PHY is up, but not currently plugged in.
> > +    NoLink,
> > +    /// PHY is performing a cable test.
> > +    CableTest,
> > +    /// Unknown, not defined in the kernel.
> > +    Unknown,
> > +}
>
> These can embed the C bindings, but it does look clunky
>
>     pub enum DeviceState {
>         Down = bindings::phy_state::PHY_DOWN as isize
>         Ready = bindings::phy_state::PHY_READY as isize,
>     }
>
> Adding `From`/`Into` `phy_state` may ease use in the future.

Just observing but usually in kernel patch reviews anything that
may have use in future should be left out.

BR, Jarkko