Re: [PATCH 00/22] make pin-init into a standalone crate

[Benno Lossin <benno.lossin@proton.me>]

On Wed Mar 5, 2025 at 3:36 PM CET, Andreas Hindborg wrote:
> "Benno Lossin" <benno.lossin@proton.me> writes:
>
>> On Wed Mar 5, 2025 at 2:56 PM CET, Andreas Hindborg wrote:
>>> Hi Benno,
>>>
>>> "Benno Lossin" <benno.lossin@proton.me> writes:
>>>
>>>> This patch series extracts the pin-init API from the kernel crate and
>>>> turns it into a standalone crate used by the kernel crate. The reasoning
>>>> for this change is that the maintenance burden for me is too great
>>>> maintaining two (more and more) diverging versions of the same library.
>>>> At [1] you can find the user-space version of the pin-init library as a
>>>> Rust crate.
>>>
>>> [...]
>>>
>>>
>>> Tested-by: Andreas Hindborg <a.hindborg@kernel.org>
>>
>> Thanks a lot for the quick reviews and testing!
>>
>>> Tested with downstream rnull driver. The driver is 71 patches on top of
>>> this series. It required a handful of trivial changes to patches that
>>> touch pin_init, but everything seems to be working just fine.
>>
>> Do you still have those trivial changes around? I would like to know
>> what kind of changes you had to do. Was it just import adjustments or
>> did you also need other changes?
>
> I pushed my branch to [1]. I folded most of the changes before I got
> lazy and put a commit on top, so you have to do a range-diff with
> v6.14-rc1..rnull-v6.14-rc1.

Thanks! Those changes are what I expected.

>> If you find the time, I would greatly appreciate if also you put your
>> rnvme driver on top and test with that.
>
> I can do that, but I have a few work items to tend to first and I go on
> PTO next week.

No worries, I think I will have to spin a new version anyways.

>>> Reviewing this series made my head spin. It must have taken a
>>> significant effort to compose the series. Thank you for making that
>>> effort!
>>
>> Yeah it wasn't easy to get the two versions on the same page again. The
>> hardest part was to split the changes into self-contained patches and
>> also to ensure nothing breaks between them.
>
> I checked every commit - nothing broken for me. Very impressive 😎

Thanks!

---
Cheers,
Benno