From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-10628.protonmail.ch (mail-10628.protonmail.ch [79.135.106.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14189257458; Wed, 12 Mar 2025 19:11:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.28 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741806663; cv=none; b=jYA0Ft9HVK+hUZcARSNFqMKqEYMpGescmSInh/PvMV2NsieQemhqDgVeBGrR7NpEL7DzTh8sdkyqudaT0+dFJOx16cfwJh6Te4vhBRxYkVI/9SzsRaRwGzUjCq8Afk2LifT2QarCebFEJKEHhzJzKCikLdB8SHafxUuQP5mnvX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741806663; c=relaxed/simple; bh=K5jtKIRj1Ea5oIHybtXIdJa/IN6jZFgqgVbH14jNNHQ=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IdbOrD7KdHif9OPNw7XdIeQ99P9DS7cTT+JnAof9y6PzWnB6RvXDYSL7pLmRwmZfgfpSEkJZyweCs7zzWOpRIGVCbd4f3Q0XfrQ5FBIsAQLNWtOjz7//B4tYuDIhJWd9/piOAHkRZvBvPNFZr6ftFOcD8bisxouVjDNhIMyFIwQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=pass smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=ShRSisAe; arc=none smtp.client-ip=79.135.106.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proton.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="ShRSisAe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1741806659; x=1742065859; bh=Fj/nMbDn3oXMvQIB/vi9kH0A2rTDre+lqjrLWiHr2Ak=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=ShRSisAeCQVbd1brnxp6coemUJ7gDPk7RCZkBzKwlzgR4SwdmvgrRpio9io1emcxU 5KOt+KIZd2I1bkw9gOAIJ4moEP6iVx8u9yPn57Wn+OW+kq9I6JFEfvqcHFvPJdtWx4 o1L8riCESO+2D4ZoDftCipm3aRtp5K6oVlv5UiioK9O2wS91VMOyVU3eyhgkWxm49O 8kNnCKZxRRbvn+jx45NIBbLx0prTlnnBFJ1Pll/S/2N+Bz8xb3QFBTW7v3Lcz0UfR3 NF8/jIJHUKxBlDvyeuWXCVLD1RBS/Tk5IUo93Hkc+BvCiMd/spOMQqn5v77To15hMW QLGt7plTCTbtw== Date: Wed, 12 Mar 2025 19:10:56 +0000 To: Tamir Duberstein From: Benno Lossin Cc: Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Bjorn Helgaas , Luis Chamberlain , Russ Weight , Rob Herring , Saravana Kannan , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 5/5] rust: enable `clippy::as_underscore` lint Message-ID: In-Reply-To: References: <20250309-ptr-as-ptr-v2-0-25d60ad922b7@gmail.com> <20250309-ptr-as-ptr-v2-5-25d60ad922b7@gmail.com> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 0d0c4b8d82d5e58811ae5b2f1a2235ac98cae2ba Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed Mar 12, 2025 at 7:01 PM CET, Tamir Duberstein wrote: > I think all the remaining comments are about strict provenance. I buy > that this is a useful thing to do, but in the absence of automated > tools to help do it, I'm not sure it's worth it to do it for just > these things I happen to be touching rather than doing it throughout. > > I couldn't find a clippy lint. Do you know of one? If not, should we > file an issue? A quick search gave me: https://doc.rust-lang.org/nightly/unstable-book/language-features/stric= t-provenance-lints.html The linked tracking issue is closed which seems like a mistake, since it's not yet stabilized. I found a different issue tracking it though: https://github.com/rust-lang/rust/issues/130351 We probably should use both in that case: #![feature(strict_provenance_lints)] #![warn(fuzzy_provenance_casts, lossy_provenance_casts)] I don't want to push more work onto this series, so it's fine to leave them in. Thus: Reviewed-by: Benno Lossin We can either make this a good-first-issue, or if you also want to tackle this, then go ahead :) --- Cheers, Benno