From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-40134.protonmail.ch (mail-40134.protonmail.ch [185.70.40.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 423EC1EE7BB for ; Wed, 12 Mar 2025 20:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.40.134 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741812169; cv=none; b=kVXi3JbYvUxLhdZ+hVuzqjUM1HHqMzzgfr7L62MNYCD+MXwTtivbUjyl50Yh6oaFf/lx+XI96OkpTFWr37dK2ZhFrTX+EBIEhHuOYiKUGn6ibAS3BRRbNOjenHeTba3XtmzYj2mV01KPe7vh1FPkPwJj2jCHvrROReqt+ces4G0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741812169; c=relaxed/simple; bh=NMh8CTxUGVQ0l/gw/OVK0SrJW3sz8Ziz94+4OJ9KoKY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YM9Ujjqx58r+YufCRd457rSsVWfpOjB2UK7W2Kx0rXHgAwnx5Kbmw+RjO8p6cOGICLxUdOd2A1nZANlwEP68FXRzysIBaMKQo/383Hp868ALZwVMpcPv0Z+iRl4P1cBzS+o7P53hDNOlikYkl+HY6l6T3edRZXXffzJZKUC00vY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=pass smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=VelFmMpe; arc=none smtp.client-ip=185.70.40.134 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proton.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="VelFmMpe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1741812164; x=1742071364; bh=pMyYkR71+rR/3IuQOyjfnVcyWj2u+Jv42qBbxPyFNk0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=VelFmMpeP25sjUu55fJ3fZ/avXxduntwL86jqVLCxygBCN58CDnlUkusQKUHigO9d DCF+SAwKWkIhg+B+aDAjVeujKhr8J2ryFYG7orE98Bz5dzi19hM1mZeT4xQndGC++7 i9uhZzkd7Wb/eBw78EQIaFdrshvQggx0tKm7YCRgmT81gjpFpt0Mrc3JaUD3MWNsZZ tfXbetviLzsF64nYStyTJyGszyfDITZqGQphnnR1Wet6PnNnHw1wyuyUJMxTl9ZAwT 2NDASusiGVP233cBxNLD0kgjT5fREUwt4Xch3uNrzyVf2TvZRmXdi+FyR1LHMva0R0 FXNIJ4Cp3En9w== Date: Wed, 12 Mar 2025 20:42:39 +0000 To: Tamir Duberstein From: Benno Lossin Cc: Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Bjorn Helgaas , Luis Chamberlain , Russ Weight , Rob Herring , Saravana Kannan , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 5/5] rust: enable `clippy::as_underscore` lint Message-ID: In-Reply-To: References: <20250309-ptr-as-ptr-v2-0-25d60ad922b7@gmail.com> <20250309-ptr-as-ptr-v2-5-25d60ad922b7@gmail.com> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 899ceb5f8eb0289fe15b927f74e6d074ac1145f5 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed Mar 12, 2025 at 9:07 PM CET, Tamir Duberstein wrote: > On Wed, Mar 12, 2025 at 3:43=E2=80=AFPM Benno Lossin wrote: >> >> On Wed Mar 12, 2025 at 8:19 PM CET, Tamir Duberstein wrote: >> > I tried using the strict provenance lints locally and I think we can't >> > until we properly bump MSRV due to `clippy::incompatible_msrv`: >> > >> > warning: current MSRV (Minimum Supported Rust Version) is `1.78.0` but >> > this item is stable since `1.84.0` >> > --> ../rust/kernel/str.rs:696:22 >> > | >> > 696 | pos: pos.expose_provenance(), >> > | ^^^^^^^^^^^^^^^^^^^ >> > | >> > =3D help: for further information visit >> > https://rust-lang.github.io/rust-clippy/master/index.html#incompatible= _msrv >> >> Oh this is annoying... >> >> > This is with `#![feature(strict_provenance)]`. I can file the issue >> > but I think it's blocked on MSRV >=3D 1.84.0. But maybe you know of a >> > path forward :) >> >> I think we should be able to just `allow(clippy::incompatible_msrv)`, >> since Miguel & other maintainers will test with 1.78 (or at least are >> supposed to :). > > Alright, you've sniped me. Sorry about that :) > This is coming in v3. Thanks a lot! --- Cheers, Benno