From: Benno Lossin <benno.lossin@proton.me>
To: "Tamir Duberstein" <tamird@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] rust: retain pointer mut-ness in `container_of!`
Date: Fri, 14 Mar 2025 19:22:09 +0000 [thread overview]
Message-ID: <D8G8F0X59XBY.1ZCW3BOLXCYP5@proton.me> (raw)
In-Reply-To: <20250307-no-offset-v1-1-0c728f63b69c@gmail.com>
On Fri Mar 7, 2025 at 10:58 PM CET, Tamir Duberstein wrote:
> Avoid casting the input pointer to `*const _`, allowing the output
> pointer to be `*mut` if the input is `*mut`. This allows a number of
> `*const` to `*mut` conversions to be removed at the cost of slightly
> worse ergonomics when the macro is used with a reference rather than a
> pointer; the only example of this was in the macro's own doctest.
>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
---
Cheers,
Benno
> ---
> rust/kernel/lib.rs | 5 ++---
> rust/kernel/pci.rs | 2 +-
> rust/kernel/platform.rs | 2 +-
> rust/kernel/rbtree.rs | 23 ++++++++++-------------
> 4 files changed, 14 insertions(+), 18 deletions(-)
next prev parent reply other threads:[~2025-03-14 19:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 21:58 [PATCH 0/2] rust: workqueue: remove HasWork::OFFSET Tamir Duberstein
2025-03-07 21:58 ` [PATCH 1/2] rust: retain pointer mut-ness in `container_of!` Tamir Duberstein
2025-03-14 19:22 ` Benno Lossin [this message]
2025-03-17 10:52 ` Alice Ryhl
2025-03-07 21:58 ` [PATCH 2/2] rust: workqueue: remove HasWork::OFFSET Tamir Duberstein
2025-03-14 19:20 ` Benno Lossin
2025-03-14 20:44 ` Tamir Duberstein
2025-03-15 9:30 ` Benno Lossin
2025-03-15 15:37 ` Tamir Duberstein
2025-03-15 18:06 ` Benno Lossin
2025-03-15 18:12 ` Tamir Duberstein
2025-03-16 12:55 ` Tamir Duberstein
2025-03-16 17:43 ` Benno Lossin
2025-03-16 18:59 ` Tamir Duberstein
2025-03-17 10:07 ` Benno Lossin
2025-03-17 11:34 ` Alice Ryhl
2025-03-17 11:35 ` Tamir Duberstein
2025-04-09 9:45 ` Alice Ryhl
2025-03-14 12:49 ` [PATCH 0/2] " Tamir Duberstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8G8F0X59XBY.1ZCW3BOLXCYP5@proton.me \
--to=benno.lossin@proton.me \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).