From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09AD64204E for ; Wed, 19 Mar 2025 00:48:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.22 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742345289; cv=none; b=LDTTtyEtBs+wWe4F4Xaf8XGZzL18jwvWSUSNW1//+7hUakHy8PIycUj1+mobdq9Gv/hgbOTDp28+jM8gJSNYfX+ZHGgSwcKZf1cAaFhTXT0nZiFQm580tZ0WcUUy2bjXWrqpBcGBWvbDHEWXM9egdh0I+yA2GkdioEimvj5LFqI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742345289; c=relaxed/simple; bh=88RSRJHHBhxMshZ3imHtSjghTe5cGLoqBCcL/vxy7IM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ryws9gDIqG/1Wz7rBA3nVJOVsS9yODYuM3NslI8WPGwUO912lnede7ClGVf2pyimafxQqfPFEVAd4I/TaIIYmhKTSI83OfNlM5DOPppAPI2YTfh9CDEVLk12LGIKMEoZFL9Oh2ty1kyZ0BYv2iWTa38ZkHwReZ1v8kDSuaHE6Wc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=pass smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=iV4TIxnu; arc=none smtp.client-ip=185.70.43.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proton.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="iV4TIxnu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1742345286; x=1742604486; bh=XsYfzUgN4o1yfTiUpKiI5jJ/eisefpfDOqZEdYuY4+A=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=iV4TIxnuhmD58RFuM537UJVfxdSHQ4Ao8bQTQPqjDwB1POfPoV57CMLc08S66SF5/ qkpQlNjhPU7KDxkZKfByxBVXs5vgsOnebEVzEObc45fnYcNbYzsc9iv5O32or4JtHT PggRnvDQhc2o/2JSHdrAjPJr5d2i9oZFPfvCwWavr8rkCNT27tLS/gB7ugORX1leNG MMfE1ZJFXu7LDu/tsRurQ+hYF3d1TqXls0oA1YBaagKLmamkydZ3p+pvwUFpRRaJDv v/Yms7SHDkz2Tghk3oukzxb8OTqCBa1/bEYGS/Dh24BMMVqAeM2OY+CgR8MF+PMys9 HvLxJiVExHvmA== Date: Wed, 19 Mar 2025 00:48:00 +0000 To: Daniel Almeida , Danilo Krummrich From: Benno Lossin Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH v7 3/3] rust: platform: allow ioremap of platform resources Message-ID: In-Reply-To: References: <20250318-topics-tyr-platform_iomem-v7-0-7438691d9ef7@collabora.com> <20250318-topics-tyr-platform_iomem-v7-3-7438691d9ef7@collabora.com> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 75237889a665dd04e655583ac856311a01bc0291 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue Mar 18, 2025 at 7:22 PM CET, Daniel Almeida wrote: > On 18 Mar 2025, at 14:43, Danilo Krummrich wrote: >> On Tue, Mar 18, 2025 at 02:20:43PM -0300, Daniel Almeida wrote: >>> + /// // Read and write a 32-bit value at `offset`. Calling `try= _access()` on >>> + /// // the `Devres` makes sure that the resource is still vali= d. >>> + /// let data =3D iomem.try_access().ok_or(ENODEV)?.readl(offse= t); >>> + /// >>> + /// iomem.try_access().ok_or(ENODEV)?.writel(data, offset); >>=20 >> I'd probably write this as >>=20 >> || -> Result { >> let iomem =3D iomem.try_access().ok_or(ENODEV)?; >>=20 >> iomem.read32(offset); >> iomem.write32(data, offset); >>=20 >> Ok(()) >> }()?; Why use a closure here? --- Cheers, Benno