From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32FE420127A; Sun, 23 Mar 2025 10:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742725792; cv=none; b=FPxuV3lcuPK84+nskB8VQ6UQFCBuzMPcveDrmjJrxMAR2Wo/84hOs+oM9YoV2BI/QwlpmhauzNWb6gVk78cTX+ozIXIWViVfCjhBNPHUMJ8oCyQclyE1dfNkENvQBnuhdiwIsRjim18OSZ0BkkFrUOjgng2pJmEa2LkyukHRf1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742725792; c=relaxed/simple; bh=fPBM9ITvuM7lirHi1AJ+7gCaDuDnmt3ZpcGmkE5puZE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tylpoWExLw+TlP1BEiPtIcYzPJGZJbINdyS0Btd32nqx2lk2WneG5fsO3X4g4NSCqiEz5HRBQ44ex01kvUbsGmWsux+JK8PM2D+zpSrOxFyr0/riOjX9dtM00IBol/roVP9FRi+R7iTUzmRY4oHayVskULpMqVWeSXm2h7QMDIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=pass smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=a8DtxVst; arc=none smtp.client-ip=185.70.43.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proton.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="a8DtxVst" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1742725788; x=1742984988; bh=l+ASOZcM9HRgZ+nz5pIJnzRypkL94hqWNP9RHmPuWTg=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=a8DtxVstiodhLlvooPtOArISro8h+o92/a0NMBGFBqo135ZJ3flUcM2FHDNiygxOK YzoLm+CpxEQOC8NlJrsRXgWOc0et5OXSeP+mxOPcHrCmic1PiTzb//YAhG46Ewq9G9 fKStdc+2jpbfrOpjK1ir1TgVxHQiSb84zT1nx9BOnknt5FNAjV+JFOWSaz0GS3lyyv Fl4ggyv/cEyQlwlwZgrnAc6P7peK4+QyISn9eD0F6VXb90ecUTA0PfZgiqU5W0Eo8g MOmvRAO06uJ34ItUF27hL5IaEp21SNpt2NQvrZsRyc9A3S9E4ZXTf5nwOHXhl9/ub0 EKDmdnIFTDLnA== Date: Sun, 23 Mar 2025 10:29:42 +0000 To: Antonio Hickey , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich From: Benno Lossin Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 02/17] rust: init: refactor to use `&raw [const|mut]` Message-ID: In-Reply-To: <20250320020740.1631171-3-contact@antoniohickey.com> References: <20250320020740.1631171-1-contact@antoniohickey.com> <20250320020740.1631171-3-contact@antoniohickey.com> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 43106bd6fd4e617b4b99b0cac304b9f6f2e8fe96 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu Mar 20, 2025 at 3:07 AM CET, Antonio Hickey wrote: > Replacing all occurrences of `addr_of_mut!(place)` > with `&raw mut place`. > > This will allow us to reduce macro complexity, and improve consistency > with existing reference syntax as `&raw mut` is similar to `&mut` > making it fit more naturally with other existing code. > > Suggested-by: Benno Lossin > Link: https://github.com/Rust-for-Linux/linux/issues/1148 > Signed-off-by: Antonio Hickey > --- > rust/kernel/init.rs | 8 ++++---- > rust/kernel/init/macros.rs | 28 ++++++++++++++-------------- > 2 files changed, 18 insertions(+), 18 deletions(-) These files have been moved in rust-next, so if you send a new version, it would be great if you could also rebase onto rust-next. --- Cheers, Benno