Re: [PATCH v3] rust: static_assert: add optional message

[Benno Lossin <benno.lossin@proton.me>]

On Tue Mar 25, 2025 at 10:10 PM CET, Altan Ozlu wrote:
> Add an optional panic message for `static_assert!` macro.

s/for/to the/

> It doesn't support argument formatting, because currently `assert!`
> doesn't allow formatting in const contextes.

I would make it even more clear:

    The panic message doesn't support argument formatting, because the
    `assert!` macro only supports formatting in non-const contexts.

>
> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1149
> Signed-off-by: Altan Ozlu <altan@ozlu.eu>
>
> ---
> Link to v2: https://lore.kernel.org/rust-for-linux/20250324210005.990827-2-altan@ozlu.eu/
> ---
>  rust/kernel/static_assert.rs | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/rust/kernel/static_assert.rs b/rust/kernel/static_assert.rs
> index 3115ee0ba8e9..b0569dccfb76 100644
> --- a/rust/kernel/static_assert.rs
> +++ b/rust/kernel/static_assert.rs
> @@ -6,6 +6,9 @@
>  ///
>  /// Similar to C11 [`_Static_assert`] and C++11 [`static_assert`].
>  ///
> +/// It supports an optional argument for custom panic messages.
> +/// The panic message doesn't support formatting.

Similarly here I think this fits better:

    You can supply an optional panic message after the expression. Currently only a string literal
    without formatting is supported due to constness limitations of the [`assert!`] macro.

---
Cheers,
Benno

> +///
>  /// The feature may be added to Rust in the future: see [RFC 2790].
>  ///
>  /// [`_Static_assert`]: https://en.cppreference.com/w/c/language/_Static_assert