From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-24418.protonmail.ch (mail-24418.protonmail.ch [109.224.244.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99A3B22C356; Thu, 17 Apr 2025 08:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744876844; cv=none; b=F+xmFLflKO+5P+OFxBZ5zZvFFLkbj+aMhTLIYfgk81Nv1tKKUloU0e5UQD78FdIuYXXoHqooBphtoHCcfCawhfCH+3fe1O/0rRs0/i5ltyG1VNJSVxxmLXJ9qbyU08gIb5U38hzKOEH6O+kNBLfqd2EsffR/abTf7RnVFyYpP+0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744876844; c=relaxed/simple; bh=h3M8nRjVuDVmfNgSsps3kLl6ltkWfwPgNKiJY+3KBX4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dYAZkrepz73f/b4EnNWEs2qBGz/mBY7GLb9gXnwy3tFfIRt4vXyuJoj67h5pn25cErBNpvidzmsuYfecOdg005HVraCqBGMZgA02fhlowAj/5qKKoIRGEFMcyVTM4dTt30RnhP2C1xEWNze53n8PFkBbJCqjwUX39FUV7TybLdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=pass smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=cKHTtMp6; arc=none smtp.client-ip=109.224.244.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proton.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="cKHTtMp6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=mo5kiaaxzzbulfrq7t524gy3u4.protonmail; t=1744876839; x=1745136039; bh=h3M8nRjVuDVmfNgSsps3kLl6ltkWfwPgNKiJY+3KBX4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=cKHTtMp6Nl4+wN4xDfq6H98VrQLHDVlci6//HiRQ8BHNReXmvAtYVxy6OehvofENJ XTeujO7jO+x96iupXZRLSVnoKBT/Hg67LA5vJs7qZqlvyNeQpQmaUgPLni4pEJjuZS QqjkQV3np8Xffo2/rGJLQ5EzAINzQajp/MMx+Wef+3lgsygugsi6OMPXXsO/v5LJEv AMWyFlkS9bfbDfjNmUradbjMR4FZ49pqH5MzHxjsIN+OwpQGcPfGjhMfOURgf8SHFK 65ijvFFbLOPZFmDolRsjMSBf8v+83Jr5J/4uTfTfdW2dP+qdb3wbu/8XhM/4aOk7pf ZDjlJxev5jWng== Date: Thu, 17 Apr 2025 08:00:33 +0000 To: Viresh Kumar , Danilo Krummrich From: Benno Lossin Cc: "Rafael J. Wysocki" , Miguel Ojeda , Danilo Krummrich , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , linux-pm@vger.kernel.org, Vincent Guittot , Stephen Boyd , Nishanth Menon , rust-for-linux@vger.kernel.org, Manos Pitsidianakis , =?utf-8?Q?Alex_Benn=C3=A9e?= , Joakim Bech , Rob Herring , Yury Norov , Burak Emir , Rasmus Villemoes , Russell King , linux-clk@vger.kernel.org, Michael Turquette , linux-kernel@vger.kernel.org Subject: Re: [PATCH V10 11/15] rust: cpufreq: Add initial abstractions for cpufreq framework Message-ID: In-Reply-To: <20250416093720.5nigxsirbvyiumcv@vireshk-i7> References: <20250416093720.5nigxsirbvyiumcv@vireshk-i7> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: ae30b957bfe6b8526ed7c4f59e8cc1d7dfe15a54 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed Apr 16, 2025 at 11:37 AM CEST, Viresh Kumar wrote: > On 16-04-25, 11:14, Danilo Krummrich wrote: >> On Wed, Apr 16, 2025 at 12:09:28PM +0530, Viresh Kumar wrote: >> > +#[allow(dead_code)] >>=20 >> Why is this needed? > > Looks like leftover from a previous version. Same for the other one. > > I have also made a change to the cpufreq driver now to remove > `dead_code`, hope that is fine: In the future, instead of using `allow`, you can try to use `expect`. It will warn, when the code is used. --- Cheers, Benno