From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 415511F16B; Thu, 15 May 2025 12:01:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747310499; cv=none; b=nZY+5x/zZCNsgqLkr/tmJib4B/nPuinIdN7v9Qd8udsP1sYqcKqp4ErLCrNRa6qrG48RvSMZQuDXSbI+gHOI6SxGThjzixBX3BmAIPoq0KLrLq75yRPXD1iCFjVOYAsJZj4fxl+cm4o57X9BsyYYQzSEh+VUXl+5Oc6pY79Ml+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747310499; c=relaxed/simple; bh=e5G8NoyYejh7bIRIp3fd5xF4gR7mdTNrW8fJ14jg26o=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=IgJfWQlqyYkXLg4Em23hejn+jTtenUNPX96vtTTVzTsO6BGxpd5w9ZNdg2+U5rRAI6mBBXp8vEaMSUQ51qr+Nz8DVmUSx9lnR2H6Bb78auhwwf0Rz8iayBSzAh0KGP3kULyDNrzVJL3UnzWxV/rCGPiponAWuc0s5ebt5XN/66Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sbbkFEfq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sbbkFEfq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B4F0C4CEE7; Thu, 15 May 2025 12:01:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747310498; bh=e5G8NoyYejh7bIRIp3fd5xF4gR7mdTNrW8fJ14jg26o=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=sbbkFEfqIp+hUc6URcnxYNfrYG91eGJsW2BvjonemLcKnpIdN/KdEmlXBO3EHBGtl mAj5fHbMojfpZveQLTI+dQD3Y9jn+3DiVDYKy4ezjcgq6EN3I6JiDKbvS6po9M2lBO qm7EFzbW/6vuj/9zUi2CxxQiRJ1fvMUxrQZeZzQq91Qc9zCzZPbIixh2okUuj42QgD EeOIpghHfGkKAo/z54CHl5qSNymy7xZTZZrxTyC7IJNIIKJqHvUYB045uk38GPFu9I t9sEKZ0FJboQmuXpgahifkx6UQIGokUa/uDm7z0MsX+QntMkFPgzkd6LSR0d3pDZhr ietuPLmcRnYOg== Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 15 May 2025 14:01:22 +0200 Message-Id: Cc: "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiner Kallweit" , "Russell King" , "Florian Fainelli" , "Broadcom internal kernel review list" , =?utf-8?q?Marek_Beh=C3=BAn?= , "Andrei Botila" , "FUJITA Tomonori" , "Trevor Gross" , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Alice Ryhl" , "Danilo Krummrich" , "Sabrina Dubroca" , "Michael Klein" , "Daniel Golle" , , , , Subject: Re: [net-next PATCH v10 7/7] rust: net::phy sync with match_phy_device C changes From: "Benno Lossin" To: "Christian Marangi" X-Mailer: aerc 0.20.1 References: <20250515112721.19323-1-ansuelsmth@gmail.com> <20250515112721.19323-8-ansuelsmth@gmail.com> <6825d53b.df0a0220.36755a.ca22@mx.google.com> In-Reply-To: <6825d53b.df0a0220.36755a.ca22@mx.google.com> On Thu May 15, 2025 at 1:51 PM CEST, Christian Marangi wrote: > On Thu, May 15, 2025 at 01:49:35PM +0200, Benno Lossin wrote: >> On Thu May 15, 2025 at 1:27 PM CEST, Christian Marangi wrote: >> > Sync match_phy_device callback wrapper in net:phy rust with the C >> > changes where match_phy_device also provide the passed PHY driver. >> > >> > As explained in the C commit, this is useful for match_phy_device to >> > access the PHY ID defined in the PHY driver permitting more generalize= d >> > functions. >> > >> > Signed-off-by: Christian Marangi >> > --- >> > rust/kernel/net/phy.rs | 26 +++++++++++++++++++++++--- >> > 1 file changed, 23 insertions(+), 3 deletions(-) >>=20 >> You probably should do this in the same commit as the C changes, >> otherwise the in-between commits will error. >>=20 > > You are right, I will fix this in v11 but I would really want to know if > the Rust changes are correct. It's not my main language so it's all > discovering new stuff :D No worries :) I have lost some context on the PHY Rust bindings, so Fujita will probably have to review it, but if I find the time, I'll take a look. --- Cheers, Benno