* [PATCH] rust: miscdevice: fix typo in MiscDevice::ioctl documentation
@ 2025-05-17 11:06 Christian Schrefl
2025-05-17 19:09 ` Benno Lossin
2025-05-19 18:09 ` Alice Ryhl
0 siblings, 2 replies; 4+ messages in thread
From: Christian Schrefl @ 2025-05-17 11:06 UTC (permalink / raw)
To: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, Danilo Krummrich, Greg Kroah-Hartman
Cc: rust-for-linux, linux-kernel, Christian Schrefl
Fixes one small typo (`utilties` to `utilities`) in the documentation of
`MiscDevice::ioctl`.
Fixes: f893691e7426 ("rust: miscdevice: add base miscdevice abstraction")
Signed-off-by: Christian Schrefl <chrisi.schrefl@gmail.com>
---
I've found this small typo while working on my `miscdevice` changes.
---
rust/kernel/miscdevice.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs
index fa9ecc42602a477328a25b5d357db90b59dc72ae..15d10e5c1db7da8f8686ed1c5d4174291231351b 100644
--- a/rust/kernel/miscdevice.rs
+++ b/rust/kernel/miscdevice.rs
@@ -121,7 +121,7 @@ fn release(device: Self::Ptr, _file: &File) {
/// Handler for ioctls.
///
- /// The `cmd` argument is usually manipulated using the utilties in [`kernel::ioctl`].
+ /// The `cmd` argument is usually manipulated using the utilities in [`kernel::ioctl`].
///
/// [`kernel::ioctl`]: mod@crate::ioctl
fn ioctl(
---
base-commit: edc5e6e019c99b529b3d1f2801d5cce9924ae79b
change-id: 20250517-rust_miscdevice_fix_typo-047a23956e09
Best regards,
--
Christian Schrefl <chrisi.schrefl@gmail.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] rust: miscdevice: fix typo in MiscDevice::ioctl documentation
2025-05-17 11:06 [PATCH] rust: miscdevice: fix typo in MiscDevice::ioctl documentation Christian Schrefl
@ 2025-05-17 19:09 ` Benno Lossin
2025-05-19 18:09 ` Alice Ryhl
1 sibling, 0 replies; 4+ messages in thread
From: Benno Lossin @ 2025-05-17 19:09 UTC (permalink / raw)
To: Christian Schrefl, Miguel Ojeda, Alex Gaynor, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
Alice Ryhl, Trevor Gross, Danilo Krummrich, Greg Kroah-Hartman
Cc: rust-for-linux, linux-kernel
On Sat May 17, 2025 at 1:06 PM CEST, Christian Schrefl wrote:
> Fixes one small typo (`utilties` to `utilities`) in the documentation of
> `MiscDevice::ioctl`.
>
> Fixes: f893691e7426 ("rust: miscdevice: add base miscdevice abstraction")
> Signed-off-by: Christian Schrefl <chrisi.schrefl@gmail.com>
> ---
> I've found this small typo while working on my `miscdevice` changes.
> ---
> rust/kernel/miscdevice.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Benno Lossin <lossin@kernel.org>
---
Cheers,
Benno
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] rust: miscdevice: fix typo in MiscDevice::ioctl documentation
2025-05-17 11:06 [PATCH] rust: miscdevice: fix typo in MiscDevice::ioctl documentation Christian Schrefl
2025-05-17 19:09 ` Benno Lossin
@ 2025-05-19 18:09 ` Alice Ryhl
2025-05-20 4:59 ` Greg Kroah-Hartman
1 sibling, 1 reply; 4+ messages in thread
From: Alice Ryhl @ 2025-05-19 18:09 UTC (permalink / raw)
To: Christian Schrefl, Greg Kroah-Hartman
Cc: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg,
Trevor Gross, Danilo Krummrich, rust-for-linux, linux-kernel
On Sat, May 17, 2025 at 01:06:15PM +0200, Christian Schrefl wrote:
> Fixes one small typo (`utilties` to `utilities`) in the documentation of
> `MiscDevice::ioctl`.
>
> Fixes: f893691e7426 ("rust: miscdevice: add base miscdevice abstraction")
> Signed-off-by: Christian Schrefl <chrisi.schrefl@gmail.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
I guess this should go through Greg's tree?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] rust: miscdevice: fix typo in MiscDevice::ioctl documentation
2025-05-19 18:09 ` Alice Ryhl
@ 2025-05-20 4:59 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2025-05-20 4:59 UTC (permalink / raw)
To: Alice Ryhl
Cc: Christian Schrefl, Miguel Ojeda, Alex Gaynor, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
Trevor Gross, Danilo Krummrich, rust-for-linux, linux-kernel
On Mon, May 19, 2025 at 06:09:10PM +0000, Alice Ryhl wrote:
> On Sat, May 17, 2025 at 01:06:15PM +0200, Christian Schrefl wrote:
> > Fixes one small typo (`utilties` to `utilities`) in the documentation of
> > `MiscDevice::ioctl`.
> >
> > Fixes: f893691e7426 ("rust: miscdevice: add base miscdevice abstraction")
> > Signed-off-by: Christian Schrefl <chrisi.schrefl@gmail.com>
>
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
>
> I guess this should go through Greg's tree?
Sure, I'll take it later today, thanks.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-20 5:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-17 11:06 [PATCH] rust: miscdevice: fix typo in MiscDevice::ioctl documentation Christian Schrefl
2025-05-17 19:09 ` Benno Lossin
2025-05-19 18:09 ` Alice Ryhl
2025-05-20 4:59 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).