rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Benno Lossin" <lossin@kernel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
	"Igor Korotin" <igor.korotin@yahoo.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v4] rust: macros: Fix macro referencing core and kernel crates
Date: Mon, 19 May 2025 16:33:10 +0200	[thread overview]
Message-ID: <DA07LSLNRJTA.3M5DBYHRUV8K7@kernel.org> (raw)
In-Reply-To: <CANiq72=ErVyyszgnH0W56Bjvakvdcprh-Z0pXt+Pc25q4z_Afg@mail.gmail.com>

On Mon May 19, 2025 at 4:20 PM CEST, Miguel Ojeda wrote:
> On Fri, May 16, 2025 at 2:35 PM Igor Korotin <igor.korotin@yahoo.com> wrote:
>>
>> diff --git a/rust/kernel/static_assert.rs b/rust/kernel/static_assert.rs
>> index d8120f838260..5e5a0bee9888 100644
>> --- a/rust/kernel/static_assert.rs
>> +++ b/rust/kernel/static_assert.rs
>> @@ -20,7 +20,7 @@
>>  ///
>>  /// ```
>>  /// static_assert!(42 > 24);
>> -/// static_assert!(core::mem::size_of::<u8>() == 1);
>> +/// static_assert!(::core::mem::size_of::<u8>() == 1);
>
> Hmm... Why are we changing this one?

Yeah this one doesn't seem necessary.

---
Cheers,
Benno

  reply	other threads:[~2025-05-19 14:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250516122349.1944895-1-igor.korotin.ref@yahoo.com>
2025-05-16 12:23 ` [PATCH v4] rust: macros: Fix macro referencing core and kernel crates Igor Korotin
2025-05-17 21:36   ` kernel test robot
2025-05-18  7:33   ` Benno Lossin
2025-05-19 14:20   ` Miguel Ojeda
2025-05-19 14:33     ` Benno Lossin [this message]
2025-05-19 16:09     ` Igor Korotin
2025-05-19 16:49       ` Miguel Ojeda
2025-05-20  8:37         ` Igor Korotin
2025-05-19 16:45   ` [PATCH v5] " igor.korotin.linux
2025-05-19 17:10     ` Miguel Ojeda
2025-05-20  8:54       ` Igor Korotin
2025-05-21 14:12     ` Miguel Ojeda
2025-05-21 15:08       ` Greg KH
2025-05-22 22:14     ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DA07LSLNRJTA.3M5DBYHRUV8K7@kernel.org \
    --to=lossin@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=igor.korotin@yahoo.com \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).