From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 307C61F4CA0; Mon, 26 May 2025 15:05:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748271949; cv=none; b=MhuSixHk/7JoG/5VhDBjLikl6RK5mqWQSLlX7eFiZiRyZLFLxWB0epM1oh69VmyesZOiMb3SKZyNCMQcoG+eoFD0w4ihXi4cTxnqTGejozcA0Ea3MRXekMSxUxcgWvJ4mhn9+sGEkVUoedNUNffohKAORsCA0ma2hmxbKiNsQ84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748271949; c=relaxed/simple; bh=ao1QQaXy2vs9T7bnqTuqdmhNzhRdF1NoeYJffk+Q+f8=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=F7b9M+QWZM1LJsiU1L+xOQv77i/7YYiIM0KmHVZmRMt9YsupeKQ1MnOiPs0IpYQQk5VBzMMZ+tJlMnDtDSYOIRpElGQBxz6psp2dbrpxSiknxkuNNRtzpDugCw1jn4ea8P6Z2EInvHb+17WGNSCG+CAMLp6+YYz7Wp5dqusddrg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=o+rC3Qza; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="o+rC3Qza" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AF23C4CEE7; Mon, 26 May 2025 15:05:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748271948; bh=ao1QQaXy2vs9T7bnqTuqdmhNzhRdF1NoeYJffk+Q+f8=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=o+rC3Qza/LbfuSE/sViz8vCK2OakU/ZSOOEhpdsbuDUkJz3KhyeyuH4lAXt+DkLW3 IhPPZZimWUrHQs8pkRzEJZ70CPLO+E/h6gaIEVyUN4sT5UrQ4Q6rcKjOnc6qg5c/Rj k3xtvN15UsbnjHAoyF2gU0LzDpN9+FVs0P/2aYS78ogS8WDh+BtHZ33BZFyGdDMQKv EHpTLrOGJnmnrjeARLBQy+a7Y4NJaPxQPK9fZmWsP/m2gBphMGpcSS0QEQIScDx4SB go6XOZ+ZHKgsykSwU25gaoSP73QOlegk6xWmFOV6P0hMylvrDEAuHTQnqD+eoF9KCH BNRs/vnIQFasA== Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 26 May 2025 17:05:36 +0200 Message-Id: Cc: , , , , , , , , , , Subject: Re: [PATCH v10 5/5] rust: remove core::ffi::CStr reexport From: "Benno Lossin" To: "Tamir Duberstein" , "Michal Rostecki" , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "Brendan Higgins" , "David Gow" , "Rae Moar" , "Danilo Krummrich" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Greg Kroah-Hartman" , "Rafael J. Wysocki" , "Luis Chamberlain" , "Russ Weight" , "FUJITA Tomonori" , "Rob Herring" , "Saravana Kannan" , "Peter Zijlstra" , "Ingo Molnar" , "Will Deacon" , "Waiman Long" , "Nathan Chancellor" , "Nick Desaulniers" , "Bill Wendling" , "Justin Stitt" , "Andrew Lunn" , "Heiner Kallweit" , "Russell King" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Bjorn Helgaas" , "Arnd Bergmann" , "Jens Axboe" , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= X-Mailer: aerc 0.20.1 References: <20250524-cstr-core-v10-0-6412a94d9d75@gmail.com> <20250524-cstr-core-v10-5-6412a94d9d75@gmail.com> In-Reply-To: <20250524-cstr-core-v10-5-6412a94d9d75@gmail.com> On Sat May 24, 2025 at 10:33 PM CEST, Tamir Duberstein wrote: > Clean up references to `kernel::str::CStr`. > > Signed-off-by: Tamir Duberstein > --- > drivers/gpu/drm/drm_panic_qr.rs | 3 ++- > drivers/gpu/nova-core/firmware.rs | 2 +- > drivers/net/phy/ax88796b_rust.rs | 1 + > drivers/net/phy/qt2025.rs | 1 + > rust/kernel/device.rs | 3 +-- > rust/kernel/driver.rs | 4 ++-- > rust/kernel/error.rs | 6 ++---- > rust/kernel/faux.rs | 5 ++++- > rust/kernel/firmware.rs | 15 ++++----------- > rust/kernel/kunit.rs | 6 +++--- > rust/kernel/lib.rs | 2 +- > rust/kernel/miscdevice.rs | 3 +-- > rust/kernel/net/phy.rs | 4 +++- > rust/kernel/of.rs | 3 ++- > rust/kernel/pci.rs | 2 +- > rust/kernel/platform.rs | 2 +- > rust/kernel/prelude.rs | 5 +---- > rust/kernel/str.rs | 22 ++++++++++------------ > rust/kernel/sync/condvar.rs | 4 ++-- > rust/kernel/sync/lock.rs | 4 ++-- > rust/kernel/sync/lock/global.rs | 5 +++-- > rust/kernel/sync/poll.rs | 1 + > rust/kernel/workqueue.rs | 1 + > rust/macros/module.rs | 2 +- > 24 files changed, 51 insertions(+), 55 deletions(-) Haven't compile tested this series yet, but this commit seems to suggest to me that some of the previous commits introduced code that doesn't compile or emits warnings? If so that needs to be fixed. --- Cheers, Benno