From: "Benno Lossin" <lossin@kernel.org>
To: "Christian Schrefl" <chrisi.schrefl@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH] rust: add `assert_sync` function
Date: Sun, 08 Jun 2025 09:41:15 +0200 [thread overview]
Message-ID: <DAGZDB274O7S.1WW1Y530WRYVY@kernel.org> (raw)
In-Reply-To: <eba1cfdd-3756-4f8e-a2b2-e15b8b8b4a18@gmail.com>
On Sun Jun 8, 2025 at 1:38 AM CEST, Christian Schrefl wrote:
> I don't see any point in paying the compile time hit for a proc macro.
>
> The Error is not that bad, just a bit worse. I just don't really see the
> point since this is only really need for marker traits and realistically
> only for `Send` and `Sync`. Also the macro would create a function
> definition for every invocation which would be a (very) small compile time
> hit. So I think that we should just add the `Send` and `Sync` functions for
> now and reconsider changing to a macro once/if more than these two is
> actually needed.
Sounds good.
---
Cheers,
Benno
next prev parent reply other threads:[~2025-06-08 7:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-07 13:02 [PATCH] rust: add `assert_sync` function Christian Schrefl
2025-06-07 15:42 ` Benno Lossin
2025-06-07 15:54 ` Christian Schrefl
2025-06-07 17:30 ` Miguel Ojeda
2025-06-07 18:11 ` Benno Lossin
2025-06-07 19:20 ` Christian Schrefl
2025-06-07 22:31 ` Benno Lossin
2025-06-07 23:38 ` Christian Schrefl
2025-06-08 7:41 ` Benno Lossin [this message]
2025-06-07 17:29 ` Miguel Ojeda
2025-06-07 20:19 ` Christian Schrefl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DAGZDB274O7S.1WW1Y530WRYVY@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=chrisi.schrefl@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).