From: "Benno Lossin" <lossin@kernel.org>
To: "Alexandre Courbot" <acourbot@nvidia.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>
Cc: <rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 4/7] rust: str: make `from_bytes_with_nul_unchecked_mut` const
Date: Wed, 18 Jun 2025 23:08:12 +0200 [thread overview]
Message-ID: <DAPYSLVCFJ81.HP8134AQOMEX@kernel.org> (raw)
In-Reply-To: <20250616-borrow_impls-v4-4-36f9beb3fe6a@nvidia.com>
On Mon Jun 16, 2025 at 5:34 AM CEST, Alexandre Courbot wrote:
> This method was probably kept non-const due to the absence of the
> `const_mut_refs` feature, but it has been enabled since the introduction
> of this code (and stabilized with Rust 1.83). Thus, make it const to
> match its non-const counterpart.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Reviewed-by: Benno Lossin <lossin@kernel.org>
---
Cheers,
Benno
> ---
> rust/kernel/str.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
next prev parent reply other threads:[~2025-06-18 21:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 3:34 [PATCH v4 0/7] rust: a few common Borrow/BorrowMut implementations Alexandre Courbot
2025-06-16 3:34 ` [PATCH v4 1/7] rust: alloc: implement `Borrow` and `BorrowMut` for `Vec` Alexandre Courbot
2025-06-18 21:45 ` Danilo Krummrich
2025-06-16 3:34 ` [PATCH v4 2/7] rust: sync: implement `Borrow` and `BorrowMut` for `Arc` types Alexandre Courbot
2025-06-29 19:31 ` Miguel Ojeda
2025-06-16 3:34 ` [PATCH v4 3/7] rust: alloc: implement `Borrow` and `BorrowMut` for `KBox` Alexandre Courbot
2025-06-18 21:46 ` Danilo Krummrich
2025-06-16 3:34 ` [PATCH v4 4/7] rust: str: make `from_bytes_with_nul_unchecked_mut` const Alexandre Courbot
2025-06-18 21:08 ` Benno Lossin [this message]
2025-06-18 21:16 ` Benno Lossin
2025-06-19 2:32 ` Alexandre Courbot
2025-06-16 3:34 ` [PATCH v4 5/7] rust: str: use transmute in `from_bytes_with_nul_unchecked_mut` Alexandre Courbot
2025-06-16 3:34 ` [PATCH v4 6/7] rust: str: implement `from_bytes_with_nul_mut` Alexandre Courbot
2025-06-16 3:34 ` [PATCH v4 7/7] rust: str: implement `Borrow` and `BorrowMut` for `CString` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DAPYSLVCFJ81.HP8134AQOMEX@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).