Re: [PATCH] rust: move ARef and AlwaysRefCounted to sync::aref

["Benno Lossin" <lossin@kernel.org>]

On Mon Jun 23, 2025 at 9:25 PM CEST, Shankari Anand wrote:
> Move the definitions of `ARef` and `AlwaysRefCounted` from `types.rs`
> to a new file `sync/aref.rs`.
> Define the corresponding `aref` module under `rust/kernel/sync.rs`.
> These types are better grouped in `sync` with other synchronization primitives.
>
> To avoid breaking existing imports, they are re-exported from `types.rs`.
> Drop unused imports `mem::ManuallyDrop`, `ptr::NonNull` from `types.rs`,
> they are now only used in `sync/aref.rs`, where they are already imported.
>
> Suggested-by: Benno Lossin <lossin@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1173
> Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
> ---
>
> The moving patch and updating patch are split as discussed in https://github.com/Rust-for-Linux/linux/issues/1173
> A follow-up patch will update all the call sites to import `ARef` and `AlwaysRefCounted`
> directly from `sync::aref` instead of `types`.

Ah, I meant that you can just send the two patches in a single series.
No need to wait for anything (it's easier to review the two distinct
changes, that's why I thought it's a good idea to split them).

> Fixes were also made to intra-doc links: unresolved references to `inc_ref` and `dec_ref`
> were updated to use `AlwaysRefCounted::inc_ref` and `AlwaysRefCounted::dec_ref`.
>
> ---
>  rust/kernel/sync.rs      |   1 +
>  rust/kernel/sync/aref.rs | 170 +++++++++++++++++++++++++++++++++++++++
>  rust/kernel/types.rs     | 156 ++---------------------------------
>  3 files changed, 176 insertions(+), 151 deletions(-)
>  create mode 100644 rust/kernel/sync/aref.rs

This doesn't apply to `rust-next` or `v6.16-rc3`, what base did you use?
When creating `.patch` files for sending, please use `--base` to make
git add your base at the bottom.

---
Cheers,
Benno