From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE91329B790; Fri, 4 Jul 2025 09:59:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751623187; cv=none; b=ZDjITSKtryE9RVaHzoJoZK1X0Rbi1NBwerWguP2rg/U4rlVcikwCgycfpV6znkxIffhYkr1stKaOUm+ooRXgvAz4x9HqXk+sritbxD7Z4g47LAe27nC/wovgAMwEQUoUbtU/b6Qk/01kyL9JY/wCEtIpgLcwPFC/XNTOiwxBEO4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751623187; c=relaxed/simple; bh=i2NX/0XGbvqHv1vq1CFp+VRtaQ0tYwiJJDPkl7hVchI=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=KVn2jxEyES+gN3JkoHUk1X3Uwr8p5FLXQkpb5xVvj+k4V1AOeClSw40tjaRarXHuey4oOVxlVj2dFvfBiVFnylO7/PTV206dQc1uYSXqE2oEusYMmTy9GA39lo+m7uE0bCTID0AzlVD0Xqefo655RtqQUk2gbNVXDQjE3c5LL0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NAv/XRZo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NAv/XRZo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C06C3C4CEE3; Fri, 4 Jul 2025 09:59:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751623187; bh=i2NX/0XGbvqHv1vq1CFp+VRtaQ0tYwiJJDPkl7hVchI=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=NAv/XRZoBqDaKXo52NCJUZhjJlI/0JD6+0jqOmjvc5+n6kUXo8WrgAbTkYNO3lGcw JzhUAj1JSkcypWKhFMT4vnk6wriwxLCOYCe3g1CfeY0MahZaYKV3j4/wpDWZYcHA7N DFkI+FCwSpJcSvF5FAbec2vjjBIDug+QJ2QP6lOmBjH9QaXWqxCzaHCAHvdqHWmMyj OTKJq5B/JLEHe0j5gqwcjJ0+RIgB2mduUspe4Wfzzc0+wnSAMHsN/hmvx5DsuDfpBh Kfs9k8nUXc9LnXxPU7IBdw3jqNPvo8vBEV/r9nlS5pl78dnCiptnkPgHUSq5RwoaO+ bEZomn9lhLcYQ== Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 04 Jul 2025 11:59:40 +0200 Message-Id: Cc: "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Alice Ryhl" , "Masahiro Yamada" , "Nathan Chancellor" , "Luis Chamberlain" , "Nicolas Schier" , "Trevor Gross" , "Adam Bratschi-Kaye" , , , , "Petr Pavlu" , "Sami Tolvanen" , "Daniel Gomez" , "Simona Vetter" , "Greg KH" , "Fiona Behrens" , "Daniel Almeida" , Subject: Re: [PATCH v14 3/7] rust: introduce module_param module From: "Benno Lossin" To: "Andreas Hindborg" , "Danilo Krummrich" X-Mailer: aerc 0.20.1 References: <20250702-module-params-v3-v14-0-5b1cc32311af@kernel.org> <20250702-module-params-v3-v14-3-5b1cc32311af@kernel.org> <0e89892f-103e-4b92-a067-e192cb7b89a6@kernel.org> <875xg8tnv7.fsf@kernel.org> <87zfdks8y2.fsf@kernel.org> In-Reply-To: <87zfdks8y2.fsf@kernel.org> On Fri Jul 4, 2025 at 9:37 AM CEST, Andreas Hindborg wrote: > Andreas Hindborg writes: > >> "Danilo Krummrich" writes: >> >>> On 7/2/25 3:18 PM, Andreas Hindborg wrote: >>>> + /// Get a shared reference to the parameter value. >>>> + // Note: When sysfs access to parameters are enabled, we have to = pass in a >>>> + // held lock guard here. >>>> + pub fn get(&self) -> &T { >>>> + self.value.as_ref().unwrap_or(&self.default) >>>> + } >>> >>> I think you forgot to rename this. >> >> Yes, thanks for being persistent on this :) > > Actually, there is a discussion on whether to keep the API similar to > `std::sync::OnceLock` [1] but also whether to rename this to something > other than `OnceLock` [2]. Depending on how that resolves, it might make > sense to stay with `get` or rename to something else. But this is for the `ModuleParamAccess`, right? There I think it makes sense to choose `access` or `value`. --- Cheers, Benno > Best regards, > Andreas Hindborg > > > [1] https://lore.kernel.org/all/35e1fef4-b715-4827-a498-bdde9b58b51c@peng= uintechs.org > [2] https://lore.kernel.org/all/CAH5fLggY2Ei14nVJzLBEoR1Rut1GKU4SZX=3D+14= tuRH1aSuQVTA@mail.gmail.com