rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Benno Lossin" <lossin@kernel.org>
To: "Andreas Hindborg" <a.hindborg@kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Masahiro Yamada" <masahiroy@kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Luis Chamberlain" <mcgrof@kernel.org>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Nicolas Schier" <nicolas.schier@linux.dev>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Adam Bratschi-Kaye" <ark.email@gmail.com>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kbuild@vger.kernel.org, "Petr Pavlu" <petr.pavlu@suse.com>,
	"Sami Tolvanen" <samitolvanen@google.com>,
	"Daniel Gomez" <da.gomez@samsung.com>,
	"Simona Vetter" <simona.vetter@ffwll.ch>,
	"Greg KH" <gregkh@linuxfoundation.org>,
	"Fiona Behrens" <me@kloenk.dev>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	linux-modules@vger.kernel.org
Subject: Re: [PATCH v15 1/7] rust: sync: add `SetOnce`
Date: Tue, 08 Jul 2025 16:19:04 +0200	[thread overview]
Message-ID: <DB6QM8WOX9FS.2W36R3YF2VS0F@kernel.org> (raw)
In-Reply-To: <87v7o2omqf.fsf@kernel.org>

On Tue Jul 8, 2025 at 3:06 PM CEST, Andreas Hindborg wrote:
> "Benno Lossin" <lossin@kernel.org> writes:
>> On Mon Jul 7, 2025 at 3:29 PM CEST, Andreas Hindborg wrote:
>>> diff --git a/rust/kernel/sync.rs b/rust/kernel/sync.rs
>>> index 81e3a806e57e2..13e6bc7fa87ac 100644
>>> --- a/rust/kernel/sync.rs
>>> +++ b/rust/kernel/sync.rs
>>> @@ -18,6 +18,7 @@
>>>  mod locked_by;
>>>  pub mod poll;
>>>  pub mod rcu;
>>> +mod set_once;
>>
>> I would have named this `once`.
>
> So module `once` and struct `SetOnce`? Struct name `Once` would lead
> thoughts to `std::sync::Once`, which is a different thing.

Hmm I thought that `Once` and `SetOnce` would live in the same module,
but if they don't then I think it's better to keep the `set_once`
module as-is.

---
Cheers,
Benno

  reply	other threads:[~2025-07-08 14:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07 13:29 [PATCH v15 0/7] rust: extend `module!` macro with integer parameter support Andreas Hindborg
2025-07-07 13:29 ` [PATCH v15 1/7] rust: sync: add `SetOnce` Andreas Hindborg
2025-07-07 13:35   ` Andreas Hindborg
2025-07-07 13:38   ` Alice Ryhl
2025-07-07 15:13     ` Boqun Feng
2025-07-08  8:54       ` Andreas Hindborg
2025-07-08  9:07         ` Benno Lossin
2025-07-09 10:34           ` Andreas Hindborg
2025-07-09 18:22             ` Benno Lossin
2025-07-09 20:12               ` Boqun Feng
2025-07-09 20:22                 ` Benno Lossin
2025-07-09 21:05                   ` Boqun Feng
2025-07-08  8:47     ` Andreas Hindborg
2025-07-08  9:00       ` Alice Ryhl
2025-07-08  9:02   ` Benno Lossin
2025-07-08 13:06     ` Andreas Hindborg
2025-07-08 14:19       ` Benno Lossin [this message]
2025-07-09  8:56         ` Andreas Hindborg
2025-07-09  9:10           ` Benno Lossin
2025-07-07 13:29 ` [PATCH v15 2/7] rust: str: add radix prefixed integer parsing functions Andreas Hindborg
2025-07-08  8:55   ` Benno Lossin
2025-07-07 13:29 ` [PATCH v15 3/7] rust: introduce module_param module Andreas Hindborg
2025-07-07 13:29 ` [PATCH v15 4/7] rust: module: use a reference in macros::module::module Andreas Hindborg
2025-07-07 13:29 ` [PATCH v15 5/7] rust: module: update the module macro with module parameter support Andreas Hindborg
2025-07-07 13:29 ` [PATCH v15 6/7] rust: samples: add a module parameter to the rust_minimal sample Andreas Hindborg
2025-07-07 13:29 ` [PATCH v15 7/7] modules: add rust modules files to MAINTAINERS Andreas Hindborg
2025-07-07 14:05 ` [PATCH v15 0/7] rust: extend `module!` macro with integer parameter support Miguel Ojeda
2025-07-08 13:09   ` Andreas Hindborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB6QM8WOX9FS.2W36R3YF2VS0F@kernel.org \
    --to=lossin@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=ark.email@gmail.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=da.gomez@samsung.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=me@kloenk.dev \
    --cc=nathan@kernel.org \
    --cc=nicolas.schier@linux.dev \
    --cc=ojeda@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=samitolvanen@google.com \
    --cc=simona.vetter@ffwll.ch \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).