From: "Trevor Gross" <tmgross@umich.edu>
To: "Onur Özkan" <work@onurozkan.dev>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com
Cc: <airlied@gmail.com>, <simona@ffwll.ch>, <ojeda@kernel.org>,
<alex.gaynor@gmail.com>, <boqun.feng@gmail.com>,
<gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
<lossin@kernel.org>, <a.hindborg@kernel.org>,
<aliceryhl@google.com>, <rafael@kernel.org>,
<viresh.kumar@linaro.org>, <gregkh@linuxfoundation.org>,
<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <davidgow@google.com>, <nm@ti.com>
Subject: Re: [PATCH v4 3/6] drivers: gpu: switch to `#[expect(...)]` in nova-core/regs.rs
Date: Tue, 08 Jul 2025 22:42:45 -0400 [thread overview]
Message-ID: <DB76FN8WH6HK.1LST75877I45J@umich.edu> (raw)
In-Reply-To: <20250701053557.20859-4-work@onurozkan.dev>
On Tue Jul 1, 2025 at 1:35 AM EDT, Onur Özkan wrote:
> This makes it clear that the warning is expected not just
> ignored, so we don't end up having various unnecessary
> linting rules in the codebase.
>
> Some parts of the codebase already use this approach, this
> patch just applies it more broadly.
>
> No functional changes.
>
> Signed-off-by: Onur Özkan <work@onurozkan.dev>
> ---
> drivers/gpu/nova-core/regs.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs
> index 5a1273230306..87e5963f1ebb 100644
> --- a/drivers/gpu/nova-core/regs.rs
> +++ b/drivers/gpu/nova-core/regs.rs
> @@ -2,7 +2,7 @@
>
> // Required to retain the original register names used by OpenRM, which are all capital snake case
> // but are mapped to types.
> -#![allow(non_camel_case_types)]
> +#![expect(non_camel_case_types)]
>
> #[macro_use]
> mod macros;
> --
> 2.50.0
Reviewed-by: Trevor Gross <tmgross@umich.edu>
next prev parent reply other threads:[~2025-07-09 2:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 5:35 [PATCH v4 0/6] replace `allow(...)` lints with `expect(...)` Onur Özkan
2025-07-01 5:35 ` [PATCH v4 1/6] rust: switch to `#[expect(...)]` in core modules Onur Özkan
2025-07-09 2:33 ` Trevor Gross
2025-07-01 5:35 ` [PATCH v4 2/6] rust: switch to `#[expect(...)]` in init and kunit Onur Özkan
2025-07-02 18:47 ` Benno Lossin
2025-07-07 13:02 ` Miguel Ojeda
2025-07-07 15:27 ` Benno Lossin
2025-07-09 2:39 ` Trevor Gross
2025-07-01 5:35 ` [PATCH v4 3/6] drivers: gpu: switch to `#[expect(...)]` in nova-core/regs.rs Onur Özkan
2025-07-09 2:42 ` Trevor Gross [this message]
2025-07-01 5:35 ` [PATCH v4 4/6] rust: switch to `#[expect(...)]` in devres, driver and ioctl Onur Özkan
2025-07-01 5:35 ` [PATCH v4 5/6] rust: remove `#[allow(clippy::unnecessary_cast)]` Onur Özkan
2025-07-09 2:37 ` Trevor Gross
2025-07-01 5:35 ` [PATCH v4 6/6] rust: remove `#[allow(clippy::non_send_fields_in_send_ty)]` Onur Özkan
2025-07-01 8:46 ` Miguel Ojeda
2025-07-01 8:43 ` [PATCH v4 0/6] replace `allow(...)` lints with `expect(...)` Miguel Ojeda
2025-07-01 17:27 ` Onur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB76FN8WH6HK.1LST75877I45J@umich.edu \
--to=tmgross@umich.edu \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=davidgow@google.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nm@ti.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=viresh.kumar@linaro.org \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).