Rust for Linux List
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Daniel Almeida" <daniel.almeida@collabora.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	"Alexandre Courbot" <acourbot@nvidia.com>
Subject: Re: [PATCH v9] rust: kernel: add support for bits/genmask macros
Date: Wed, 16 Jul 2025 22:06:54 +0200	[thread overview]
Message-ID: <DBDR0X23V1Z8.B3FYX0G7XTCZ@kernel.org> (raw)
In-Reply-To: <DBDQNDJDV41H.I58GXBM55PVG@kernel.org>

On Wed Jul 16, 2025 at 9:49 PM CEST, Danilo Krummrich wrote:
> On Wed Jul 16, 2025 at 9:44 PM CEST, Daniel Almeida wrote:
>> I guess this is the same problem as u64: drivers will usually have either
>> i32s/u32s and this would require a cast.
>
> I don't understand this argument? We usualy use usize for such things, no?

I already thought in terms of the register!() macro, which deals with target
types for us anyways. Without that, you're right, u32 is better.

  reply	other threads:[~2025-07-16 20:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-14 23:29 [PATCH v9] rust: kernel: add support for bits/genmask macros Daniel Almeida
2025-07-16 18:38 ` Danilo Krummrich
2025-07-16 19:11   ` Daniel Almeida
2025-07-16 19:18     ` Daniel Almeida
2025-07-16 19:32     ` Danilo Krummrich
2025-07-16 19:44       ` Daniel Almeida
2025-07-16 19:49         ` Danilo Krummrich
2025-07-16 20:06           ` Danilo Krummrich [this message]
2025-07-16 20:07 ` Danilo Krummrich
2025-07-19 22:17 ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBDR0X23V1Z8.B3FYX0G7XTCZ@kernel.org \
    --to=dakr@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox