rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Benno Lossin" <lossin@kernel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>
Cc: "Shankari Anand" <shankari.ak0208@gmail.com>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Dave Ertman" <david.m.ertman@intel.com>,
	"Ira Weiny" <ira.weiny@intel.com>,
	"Leon Romanovsky" <leon@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Abdiel Janulgue" <abdiel.janulgue@gmail.com>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Viresh Kumar" <vireshk@kernel.org>, "Nishanth Menon" <nm@ti.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>
Subject: Re: [PATCH 7/7] rust: kernel: update ARef and AlwaysRefCounted imports from sync::aref
Date: Sun, 27 Jul 2025 19:20:02 +0200	[thread overview]
Message-ID: <DBN0D5J10BH9.3I1FHJC1KZ79A@kernel.org> (raw)
In-Reply-To: <CANiq72nBHtbZqt8R0dMSK6iWY7Z3vKLbeP_2dN2NaLOxRfOvCA@mail.gmail.com>

On Sun Jul 27, 2025 at 4:26 PM CEST, Miguel Ojeda wrote:
> On Sun, Jul 27, 2025 at 2:37 PM Benno Lossin <lossin@kernel.org> wrote:
>>
>> That's good advice. I want to add that in this case, I think a series is
>> better sending 7 independent patches. Using a series allows people to
>> see if it is complete (ie there might be places that are missed). It
>> also allows someone to send a single mail reviewing all patches & giving
>> general comments about all patches in the series.
>
> It is fine if places are missed, since in this case they are not meant
> to be applied at once -- maintainers may think they are supposed to
> give Acked-bys instead of applying them, and here the idea was to try
> to see if we could get a migration like this via different trees
> slowly, rather than the way we did the others.

AFAIK maintainers can pick different parts of a series', right?

> For the "final series" that removes the re-export, it should
> definitely be a series, because in such a case the idea is to apply
> them all and remove the re-export at the end of it.
>
> I guess it depends a bit on what maintainers want to do and the case
> (e.g. if it is a tricky change, it may be best to have a series).
> Sometimes same people may do it differently, e.g. [1][2].
>
> But I agree that many independent patches are painful too, including
> in Lore; and that it is always nice to have an "index" of all the
> patches for those that want to see it as you say -- perhaps providing
> a link to a Lore search, or having them all in the same thread can
> help (though that can be confusing on its own), or having a first RFC
> version as a series that can be linked later before splitting.

This is the main benefit in this case I'd say.

---
Cheers,
Benno

>
> Cheers,
> Miguel
>
> [1] https://lore.kernel.org/all/20241127091036.444330-2-u.kleine-koenig@baylibre.com/
> [2] https://lore.kernel.org/lkml/20221118224540.619276-1-uwe@kleine-koenig.org/

  reply	other threads:[~2025-07-27 17:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-17  7:34 [PATCH 7/7] rust: kernel: update ARef and AlwaysRefCounted imports from sync::aref Shankari Anand
2025-07-25 13:02 ` Shankari Anand
2025-07-25 14:03   ` Miguel Ojeda
2025-07-27  7:30     ` Shankari Anand
2025-07-27 12:28       ` Miguel Ojeda
2025-07-27 12:37         ` Benno Lossin
2025-07-27 14:26           ` Miguel Ojeda
2025-07-27 17:20             ` Benno Lossin [this message]
2025-07-27 18:05               ` Miguel Ojeda
2025-08-01  8:39     ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBN0D5J10BH9.3I1FHJC1KZ79A@kernel.org \
    --to=lossin@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=abdiel.janulgue@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=david.m.ertman@intel.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=ira.weiny@intel.com \
    --cc=kwilczynski@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=nm@ti.com \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=shankari.ak0208@gmail.com \
    --cc=tmgross@umich.edu \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).