From: "Danilo Krummrich" <dakr@kernel.org>
To: "herculoxz" <abhinav.ogl@gmail.com>
Cc: <bhelgaas@google.com>, <kwilczynski@kernel.org>,
<ojeda@kernel.org>, <alex.gaynor@gmail.com>,
<boqun.feng@gmail.com>, <gary@garyguo.net>,
<bjorn3_gh@protonmail.com>, <lossin@kernel.org>,
<a.hindborg@kernel.org>, <aliceryhl@google.com>,
<tmgross@umich.edu>, <linux-pci@vger.kernel.org>,
<rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rust: pci: use c_* types via kernel prelude
Date: Tue, 29 Jul 2025 11:45:30 +0200 [thread overview]
Message-ID: <DBOFY80IDMWJ.627ZOACP7KK5@kernel.org> (raw)
In-Reply-To: <20250729002941.7643-1-abhinav.ogl@gmail.com>
Hi Abhinav,
On Tue Jul 29, 2025 at 2:29 AM CEST, herculoxz wrote:
> From: Abhinav Ananthu <abhinav.ogl@gmail.com>
>
> Update PCI FFI callback signatures to use from the ,
> instead of accessing it via . This aligns with the Rust-for-Linux coding
> guidelines and ensures ABI correctness when interfacing with C code.
Something seems to be odd with the commit message, it seems some parts are
missing.
Can you please fix this and send a v2? It's enough to send it after -rc1 is out.
Thanks,
Danilo
next prev parent reply other threads:[~2025-07-29 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 0:29 [PATCH] rust: pci: use c_* types via kernel prelude herculoxz
2025-07-29 9:45 ` Danilo Krummrich [this message]
2025-07-29 10:10 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBOFY80IDMWJ.627ZOACP7KK5@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=abhinav.ogl@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).