[PATCH 2/7] rust: gpu: update ARef and AlwaysRefCounted imports from sync::aref

[PATCH 2/7] rust: gpu: update ARef and AlwaysRefCounted imports from sync::aref

[Shankari Anand]

Update call sites under gpu to import `ARef` and
`AlwaysRefCounted` from `sync::aref` instead of `types`.

This aligns with the ongoing effort to move `ARef` and
`AlwaysRefCounted` to sync.

Suggested-by: Benno Lossin <lossin@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1173
Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
---
It part of a subsystem-wise split series, as suggested in:
https://lore.kernel.org/rust-for-linux/CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@mail.gmail.com/T/#u
This split series is intended to ease review and subsystem-level maintenance.

The original moving patch is here:
https://lore.kernel.org/rust-for-linux/20250625111133.698481-1-shankari.ak0208@gmail.com/

Gradually the re-export from types.rs will be eliminated in the
future cycle.
---
 drivers/gpu/drm/nova/driver.rs | 4 +++-
 drivers/gpu/drm/nova/gem.rs    | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova/driver.rs
index b28b2e05cc15..91b7380f83ab 100644
--- a/drivers/gpu/drm/nova/driver.rs
+++ b/drivers/gpu/drm/nova/driver.rs
@@ -1,6 +1,8 @@
 // SPDX-License-Identifier: GPL-2.0
 
-use kernel::{auxiliary, c_str, device::Core, drm, drm::gem, drm::ioctl, prelude::*, types::ARef};
+use kernel::{
+    auxiliary, c_str, device::Core, drm, drm::gem, drm::ioctl, prelude::*, sync::aref::ARef,
+};
 
 use crate::file::File;
 use crate::gem::NovaObject;
diff --git a/drivers/gpu/drm/nova/gem.rs b/drivers/gpu/drm/nova/gem.rs
index 33b62d21400c..cd82773dab92 100644
--- a/drivers/gpu/drm/nova/gem.rs
+++ b/drivers/gpu/drm/nova/gem.rs
@@ -4,7 +4,7 @@
     drm,
     drm::{gem, gem::BaseObject},
     prelude::*,
-    types::ARef,
+    sync::aref::ARef,
 };
 
 use crate::{
-- 
2.34.1

Re: [PATCH 2/7] rust: gpu: update ARef and AlwaysRefCounted imports from sync::aref

[Shankari Anand]

Hello, can this patch be picked up for review?

--
Thanks and Regards,
Shankari

On Wed, Jul 16, 2025 at 2:40 PM Shankari Anand
<shankari.ak0208@gmail.com> wrote:
>
> Update call sites under gpu to import `ARef` and
> `AlwaysRefCounted` from `sync::aref` instead of `types`.
>
> This aligns with the ongoing effort to move `ARef` and
> `AlwaysRefCounted` to sync.
>
> Suggested-by: Benno Lossin <lossin@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1173
> Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
> ---
> It part of a subsystem-wise split series, as suggested in:
> https://lore.kernel.org/rust-for-linux/CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@mail.gmail.com/T/#u
> This split series is intended to ease review and subsystem-level maintenance.
>
> The original moving patch is here:
> https://lore.kernel.org/rust-for-linux/20250625111133.698481-1-shankari.ak0208@gmail.com/
>
> Gradually the re-export from types.rs will be eliminated in the
> future cycle.
> ---
>  drivers/gpu/drm/nova/driver.rs | 4 +++-
>  drivers/gpu/drm/nova/gem.rs    | 2 +-
>  2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova/driver.rs
> index b28b2e05cc15..91b7380f83ab 100644
> --- a/drivers/gpu/drm/nova/driver.rs
> +++ b/drivers/gpu/drm/nova/driver.rs
> @@ -1,6 +1,8 @@
>  // SPDX-License-Identifier: GPL-2.0
>
> -use kernel::{auxiliary, c_str, device::Core, drm, drm::gem, drm::ioctl, prelude::*, types::ARef};
> +use kernel::{
> +    auxiliary, c_str, device::Core, drm, drm::gem, drm::ioctl, prelude::*, sync::aref::ARef,
> +};
>
>  use crate::file::File;
>  use crate::gem::NovaObject;
> diff --git a/drivers/gpu/drm/nova/gem.rs b/drivers/gpu/drm/nova/gem.rs
> index 33b62d21400c..cd82773dab92 100644
> --- a/drivers/gpu/drm/nova/gem.rs
> +++ b/drivers/gpu/drm/nova/gem.rs
> @@ -4,7 +4,7 @@
>      drm,
>      drm::{gem, gem::BaseObject},
>      prelude::*,
> -    types::ARef,
> +    sync::aref::ARef,
>  };
>
>  use crate::{
> --
> 2.34.1
>

Re: [PATCH 2/7] rust: gpu: update ARef and AlwaysRefCounted imports from sync::aref

[Danilo Krummrich]

On 7/31/25 3:37 PM, Shankari Anand wrote:
> Hello, can this patch be picked up for review?

Where is the rest of the series?

Re: [PATCH 2/7] rust: gpu: update ARef and AlwaysRefCounted imports from sync::aref

[Shankari Anand]

> Where is the rest of the series?
So actually it's spread across various subsystems. I had given the
notation (2/7) to have a count of the patches under the same effort.
Apologies for the misinterpretation.
But yes, recently Miguel suggested discontinuing using the notation
but as I had sent the patch long back, I didn't resend it.

If it is confusing, then I'll resend it without the series notation.
But, this is basically a standalone patch.

Thanks




On Thu, Jul 31, 2025 at 7:23 PM Danilo Krummrich <dakr@kernel.org> wrote:
>
> On 7/31/25 3:37 PM, Shankari Anand wrote:
> > Hello, can this patch be picked up for review?
>
> Where is the rest of the series?

Re: [PATCH 2/7] rust: gpu: update ARef and AlwaysRefCounted imports from sync::aref

[Danilo Krummrich]

On Thu Jul 31, 2025 at 3:59 PM CEST, Shankari Anand wrote:
>> Where is the rest of the series?
> So actually it's spread across various subsystems. I had given the
> notation (2/7) to have a count of the patches under the same effort.
> Apologies for the misinterpretation.
> But yes, recently Miguel suggested discontinuing using the notation
> but as I had sent the patch long back, I didn't resend it.
>
> If it is confusing, then I'll resend it without the series notation.
> But, this is basically a standalone patch.

Ok, did you send the other ones already? I don't see them anywhere.

NIT: Please don't top post. [1]

[1] https://docs.kernel.org/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions

Re: [PATCH 2/7] rust: gpu: update ARef and AlwaysRefCounted imports from sync::aref

[Shankari Anand]

On Thu Jul 31, 2025 at 14:54 UTC, Danilo Krummrich wrote:
>
> Ok, did you send the other ones already? I don't see them anywhere.

The commit 07dad44aa9a9 ("rust: kernel: move ARef and AlwaysRefCounted
to sync::aref ") refers to the patch where ARef and AlwaysRefCounted
were moved into a different file. [1]
To update the call-sites accordingly, I was advised to split the
changes by subsystem so each patch could be reviewed and acked by the
respective maintainers. [2]
These patches are all part of that same effort, although they aren't
shown as a formal series since the subject lines vary to reflect the
specific files they touch. [3] [4] [5] [6] [7]

> NIT: Please don't top post. [1]

> [1] https://docs.kernel.org/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions

Apologies, I’ll make sure to follow the interleaved style.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=07dad44aa9a93b16af19e8609a10b241c352b440
[2] https://lore.kernel.org/rust-for-linux/CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@mail.gmail.com/T/#u
[3] https://lore.kernel.org/rust-for-linux/20250716090712.809750-1-shankari.ak0208@gmail.com/
[4] https://lore.kernel.org/rust-for-linux/20250716091158.812860-1-shankari.ak0208@gmail.com/
[5] https://lore.kernel.org/rust-for-linux/20250716091827.816971-1-shankari.ak0208@gmail.com/
[6] https://lore.kernel.org/rust-for-linux/20250717072724.14602-1-shankari.ak0208@gmail.com/
[7] https://lore.kernel.org/rust-for-linux/20250717073108.14943-1-shankari.ak0208@gmail.com/



On Thu, Jul 31, 2025 at 8:24 PM Danilo Krummrich <dakr@kernel.org> wrote:
>
> On Thu Jul 31, 2025 at 3:59 PM CEST, Shankari Anand wrote:
> >> Where is the rest of the series?
> > So actually it's spread across various subsystems. I had given the
> > notation (2/7) to have a count of the patches under the same effort.
> > Apologies for the misinterpretation.
> > But yes, recently Miguel suggested discontinuing using the notation
> > but as I had sent the patch long back, I didn't resend it.
> >
> > If it is confusing, then I'll resend it without the series notation.
> > But, this is basically a standalone patch.
>
> Ok, did you send the other ones already? I don't see them anywhere.
>
> NIT: Please don't top post. [1]
>
> [1] https://docs.kernel.org/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions

Re: [PATCH 2/7] rust: gpu: update ARef and AlwaysRefCounted imports from sync::aref

[Danilo Krummrich]

On Thu Jul 31, 2025 at 7:50 PM CEST, Shankari Anand wrote:
> On Thu Jul 31, 2025 at 14:54 UTC, Danilo Krummrich wrote:
>>
>> Ok, did you send the other ones already? I don't see them anywhere.
>
> The commit 07dad44aa9a9 ("rust: kernel: move ARef and AlwaysRefCounted
> to sync::aref ") refers to the patch where ARef and AlwaysRefCounted
> were moved into a different file. [1]
> To update the call-sites accordingly, I was advised to split the
> changes by subsystem so each patch could be reviewed and acked by the
> respective maintainers. [2]
> These patches are all part of that same effort, although they aren't
> shown as a formal series since the subject lines vary to reflect the
> specific files they touch. [3] [4] [5] [6] [7]
>
>> NIT: Please don't top post. [1]
>
>> [1] https://docs.kernel.org/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions
>
> Apologies, I’ll make sure to follow the interleaved style.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=07dad44aa9a93b16af19e8609a10b241c352b440
> [2] https://lore.kernel.org/rust-for-linux/CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@mail.gmail.com/T/#u
> [3] https://lore.kernel.org/rust-for-linux/20250716090712.809750-1-shankari.ak0208@gmail.com/
> [4] https://lore.kernel.org/rust-for-linux/20250716091158.812860-1-shankari.ak0208@gmail.com/
> [5] https://lore.kernel.org/rust-for-linux/20250716091827.816971-1-shankari.ak0208@gmail.com/
> [6] https://lore.kernel.org/rust-for-linux/20250717072724.14602-1-shankari.ak0208@gmail.com/
> [7] https://lore.kernel.org/rust-for-linux/20250717073108.14943-1-shankari.ak0208@gmail.com/

Ok, I see what happened. :)

I think you may have misunderstood the suggested of splitting things "by
subsystem". Let's take [7] and [8] for instance.

In [7] you update all the samples, regardless of their subsystem affinity and
[8] updates everything under rust/kernel/.

However, the idea was to send a separate patch per maintainers entry / tree,
such that all patches can be picked in the corresponding tree.

For instance, one patch should be everything that goes through driver-core:
auxiliary, PCI (incl. sample), platform (incl. sample), device, devres.

Then you have another patch for only DMA (incl. sample), etc.

Can you please resend accordingly? Ideally, wait for -rc1 to be out, or base
your changes on -next.

[8] https://lore.kernel.org/lkml/20250717073450.15090-1-shankari.ak0208@gmail.com/

"Re: [PATCH 2/7] rust: gpu: update ARef and AlwaysRefCounted imports from sync::aref"

[Shankari Anand]

On Fri, Aug 01, 2025 at 10:36:44AM +0200, Danilo Krummrich wrote:
> >
> >> NIT: Please don't top post. [1]
> >
> >> [1] https://docs.kernel.org/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions
> >
> > Apologies, I’ll make sure to follow the interleaved style.
> >
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=07dad44aa9a93b16af19e8609a10b241c352b440
> > [2] https://lore.kernel.org/rust-for-linux/CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@mail.gmail.com/T/#u
> > [3] https://lore.kernel.org/rust-for-linux/20250716090712.809750-1-shankari.ak0208@gmail.com/
> > [4] https://lore.kernel.org/rust-for-linux/20250716091158.812860-1-shankari.ak0208@gmail.com/
> > [5] https://lore.kernel.org/rust-for-linux/20250716091827.816971-1-shankari.ak0208@gmail.com/
> > [6] https://lore.kernel.org/rust-for-linux/20250717072724.14602-1-shankari.ak0208@gmail.com/
> > [7] https://lore.kernel.org/rust-for-linux/20250717073108.14943-1-shankari.ak0208@gmail.com/
> 
> Ok, I see what happened. :)
> 
> I think you may have misunderstood the suggested of splitting things "by
> subsystem". Let's take [7] and [8] for instance.
> 
> In [7] you update all the samples, regardless of their subsystem affinity and
> [8] updates everything under rust/kernel/.
> 
> However, the idea was to send a separate patch per maintainers entry / tree,
> such that all patches can be picked in the corresponding tree.
> 
 I understood my mistake now. Thanks for clarifying!
 I'll split it out correctly and resend them.

> For instance, one patch should be everything that goes through driver-core:
> auxiliary, PCI (incl. sample), platform (incl. sample), device, devres.
> 
> Then you have another patch for only DMA (incl. sample), etc.
> 
 This particular patch in the series is restricted to inclusion of only gpu driver files.
 Can this be picked up separately or should I be merging it with any other driver?

> Can you please resend accordingly? Ideally, wait for -rc1 to be out, or base
> your changes on -next.
> 
> [8] https://lore.kernel.org/lkml/20250717073450.15090-1-shankari.ak0208@gmail.com/

Thanks and regards,
Shankari

Re: "Re: [PATCH 2/7] rust: gpu: update ARef and AlwaysRefCounted imports from sync::aref"

[Danilo Krummrich]

On Wed Aug 13, 2025 at 4:28 PM CEST, Shankari Anand wrote:
>  This particular patch in the series is restricted to inclusion of only gpu driver files.
>  Can this be picked up separately or should I be merging it with any other driver?

This specific one is fine, I'll pick it up soon.

Re: [PATCH 2/7] rust: gpu: update ARef and AlwaysRefCounted imports from sync::aref

[Danilo Krummrich]

On Wed Jul 16, 2025 at 11:09 AM CEST, Shankari Anand wrote:
> Update call sites under gpu to import `ARef` and
> `AlwaysRefCounted` from `sync::aref` instead of `types`.
>
> This aligns with the ongoing effort to move `ARef` and
> `AlwaysRefCounted` to sync.
>
> Suggested-by: Benno Lossin <lossin@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1173
> Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>

Applied to nova-next, thanks!

    [ Alter subject and commit message to be nova specific. - Danilo ]