From: "Benno Lossin" <lossin@kernel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Areej Hamid" <areejhamid8560@gmail.com>
Cc: <rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<ojeda@kernel.org>, <alex.gaynor@gmail.com>,
<boqun.feng@gmail.com>, <gary@garyguo.net>,
<bjorn3_gh@protonmail.com>, <a.hindborg@linaro.org>,
<aliceryhl@google.com>, <tmgross@umich.edu>, <dakr@kernel.org>,
<viresh.kumar@linaro.org>, <tamird@gmail.com>,
<dingxiangfei2009@gmail.com>, <gregkh@linuxfoundation.org>,
<thomas.weissschuh@domain.com>
Subject: Re: [PATCH v2] rust: lib: add if_cfg! macro for conditional compilation
Date: Fri, 15 Aug 2025 10:16:07 +0200 [thread overview]
Message-ID: <DC2UP1Q4D5L3.2SOGYHJGXPTWS@kernel.org> (raw)
In-Reply-To: <CANiq72mbTqu8KuKn1uKM8czesrg+or-S3K9e_ohJz1b6kzdffw@mail.gmail.com>
On Thu Aug 14, 2025 at 8:49 PM CEST, Miguel Ojeda wrote:
> By the way, Tamir suggested in the linked Rust for Linux issue to
> match the name of the upstream one in case we want to migrate to the
> standard library one eventually. In the commit message, I would also
> mention this and link to the tracking issue that Trevor mentioned:
> https://github.com/rust-lang/rust/issues/115585.
Didn't we also want to vendor the `cfg-if` crate? Or am I missing
something?
> Finally, we may want to consider putting this into somewhere else,
> rather than the root file of the crate.
Yeah, let's have it in a `cfg_if.rs` or whatever the macro will be
called.
---
Cheers,
Benno
next prev parent reply other threads:[~2025-08-15 8:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 20:38 [PATCH] rust: lib: add if_cfg! macro for conditional compilation Areej
2025-08-13 20:59 ` Thomas Weißschuh
[not found] ` <CAMjM9+b60ate7cpHfm6uPHFauuYyPA1KcukqMgLjCQcC_zak+A@mail.gmail.com>
2025-08-14 5:07 ` Thomas Weißschuh
2025-08-14 16:22 ` [PATCH v2] " Areej Hamid
2025-08-14 18:49 ` Miguel Ojeda
2025-08-14 18:54 ` Miguel Ojeda
2025-08-15 8:16 ` Benno Lossin [this message]
2025-08-14 5:55 ` [PATCH] " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC2UP1Q4D5L3.2SOGYHJGXPTWS@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@linaro.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=areejhamid8560@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=dingxiangfei2009@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=thomas.weissschuh@domain.com \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).