Re: [PATCH v4 4/7] rust: page: define trait AsPageIter

["Alexandre Courbot" <acourbot@nvidia.com>]

On Mon Aug 18, 2025 at 9:07 PM JST, Danilo Krummrich wrote:
> On 8/18/25 2:06 PM, Alexandre Courbot wrote:
>> On Thu Aug 14, 2025 at 6:33 PM JST, Danilo Krummrich wrote:
>>> +/// Trait to be implemented by types, which provide an [`Iterator`] implementation of
>>> +/// [`BorrowedPage`] items, such as [`VmallocPageIter`](kernel::alloc::allocator::VmallocPageIter).
>>> +pub trait AsPageIter {
>>> +    /// The [`Iterator`] type, e.g. [`VmallocPageIter`](kernel::alloc::allocator::VmallocPageIter).
>>> +    type Iter<'a>: Iterator<Item = BorrowedPage<'a>>
>>> +    where
>>> +        Self: 'a;
>>> +
>>> +    /// Returns an [`Iterator`] of [`BorrowedPage`] items over all pages owned by `self`.
>> 
>> This is almost obvious, but maybe specify that the pages must be
>> returned in ascending mapping order?
>
> There is no requirement for AsPageIter that the pages need to be mapped in any
> address space.

Yet, isn't the order of iteration important even if we don't intent to
map the pages?