From: "Danilo Krummrich" <dakr@kernel.org>
To: "Alice Ryhl" <aliceryhl@google.com>
Cc: <lorenzo.stoakes@oracle.com>, <vbabka@suse.cz>,
<Liam.Howlett@oracle.com>, <urezki@gmail.com>, <ojeda@kernel.org>,
<alex.gaynor@gmail.com>, <boqun.feng@gmail.com>,
<gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
<lossin@kernel.org>, <a.hindborg@kernel.org>, <tmgross@umich.edu>,
<abdiel.janulgue@gmail.com>, <acourbot@nvidia.com>,
<rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v4 3/7] rust: alloc: implement VmallocPageIter
Date: Tue, 19 Aug 2025 14:02:58 +0200 [thread overview]
Message-ID: <DC6E0X5AIJPA.9B5HPG419G4O@kernel.org> (raw)
In-Reply-To: <aKRknP8HT-BrPok4@google.com>
On Tue Aug 19, 2025 at 1:48 PM CEST, Alice Ryhl wrote:
> On Thu, Aug 14, 2025 at 11:33:42AM +0200, Danilo Krummrich wrote:
>> +impl<'a> VmallocPageIter<'a> {
>> + /// Creates a new [`VmallocPageIter`] instance.
>> + ///
>> + /// # Safety
>> + ///
>> + /// - `buf` must be a pointer to the beginning of a [`Vmalloc`] allocation.
>
> It has to be the beginning of the vmalloc allocation?
Technically, it would probably be enough if the pointer is a PAGE_SIZE aligned
pointer within a Vmalloc allocation and `size` is the remaining size, etc.
I can relax the requirement accordingly.
next prev parent reply other threads:[~2025-08-19 12:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 9:33 [PATCH v4 0/7] BorrowedPage, AsPageIter and VmallocPageIter Danilo Krummrich
2025-08-14 9:33 ` [PATCH v4 1/7] rust: page: implement BorrowedPage Danilo Krummrich
2025-08-19 12:42 ` Daniel Almeida
2025-08-14 9:33 ` [PATCH v4 2/7] rust: alloc: vmalloc: implement Vmalloc::to_page() Danilo Krummrich
2025-08-19 12:46 ` Daniel Almeida
2025-08-14 9:33 ` [PATCH v4 3/7] rust: alloc: implement VmallocPageIter Danilo Krummrich
2025-08-18 12:02 ` Alexandre Courbot
2025-08-19 11:48 ` Alice Ryhl
2025-08-19 12:02 ` Danilo Krummrich [this message]
2025-08-19 12:58 ` Daniel Almeida
2025-08-14 9:33 ` [PATCH v4 4/7] rust: page: define trait AsPageIter Danilo Krummrich
2025-08-18 12:06 ` Alexandre Courbot
2025-08-18 12:07 ` Danilo Krummrich
2025-08-18 12:14 ` Alexandre Courbot
2025-08-18 12:18 ` Danilo Krummrich
2025-08-19 11:49 ` Alice Ryhl
2025-08-19 13:08 ` Daniel Almeida
2025-08-19 13:16 ` Danilo Krummrich
2025-08-14 9:33 ` [PATCH v4 5/7] rust: alloc: kbox: implement AsPageIter for VBox Danilo Krummrich
2025-08-18 12:07 ` Alexandre Courbot
2025-08-19 11:50 ` Alice Ryhl
2025-08-19 12:06 ` Danilo Krummrich
2025-08-14 9:33 ` [PATCH v4 6/7] rust: alloc: layout: implement ArrayLayout::size() Danilo Krummrich
2025-08-14 9:33 ` [PATCH v4 7/7] rust: alloc: kvec: implement AsPageIter for VVec Danilo Krummrich
2025-08-18 12:09 ` Alexandre Courbot
2025-08-19 11:51 ` Alice Ryhl
2025-08-19 13:11 ` Daniel Almeida
2025-08-18 12:11 ` [PATCH v4 0/7] BorrowedPage, AsPageIter and VmallocPageIter Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC6E0X5AIJPA.9B5HPG419G4O@kernel.org \
--to=dakr@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=abdiel.janulgue@gmail.com \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=lorenzo.stoakes@oracle.com \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).