From: "Benno Lossin" <lossin@kernel.org>
To: "Alice Ryhl" <aliceryhl@google.com>, "Jesung Yang" <y.j3ms.n@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
nouveau@lists.freedesktop.org
Subject: Re: [PATCH v2 2/5] rust: macros: extend custom `quote!()` macro
Date: Thu, 28 Aug 2025 09:14:14 +0200 [thread overview]
Message-ID: <DCDVIR91LFHQ.1C87G5A0OBJ39@kernel.org> (raw)
In-Reply-To: <CAH5fLgjyd7zNqLFT4T0_=tzcPFyw9xwZX+QTA8ShBxZ_Fa6o6Q@mail.gmail.com>
On Thu Aug 28, 2025 at 8:39 AM CEST, Alice Ryhl wrote:
> On Fri, Aug 15, 2025 at 7:32 AM Jesung Yang <y.j3ms.n@gmail.com> wrote:
>> + (@proc $v:ident $span:ident == $($tt:tt)*) => {
>> + $v.push(::proc_macro::TokenTree::Punct(
>> + ::proc_macro::Punct::new('=', ::proc_macro::Spacing::Joint)
>> + ));
>> + $v.push(::proc_macro::TokenTree::Punct(
>> + ::proc_macro::Punct::new('=', ::proc_macro::Spacing::Alone)
>> + ));
>> + quote_spanned!(@proc $v $span $($tt)*);
>
> Not a blocker, but if the way to implement this one is to push =
> twice, then I think the pattern should just be a single = and then you
> push a = once. The pattern can match twice to handle ==.
You can't do that, since the first one needs the `Joint` spacing and the
second one the `Alone` one. `==` also is a single token in macro input,
so matching only on `=` doesn't work.
---
Cheers,
Benno
next prev parent reply other threads:[~2025-08-28 7:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 5:32 [PATCH v2 0/5] rust: add `TryFrom` and `Into` derive macros Jesung Yang
2025-08-15 5:32 ` [PATCH v2 1/5] rust: macros: allow conversion from `&T` to `TokenStream` Jesung Yang
2025-08-15 5:32 ` [PATCH v2 2/5] rust: macros: extend custom `quote!()` macro Jesung Yang
2025-08-28 6:39 ` Alice Ryhl
2025-08-28 7:14 ` Benno Lossin [this message]
2025-08-28 13:05 ` Alice Ryhl
2025-08-15 5:32 ` [PATCH v2 3/5] rust: macros: prefix variable `span` with underscore Jesung Yang
2025-08-15 5:32 ` [PATCH v2 4/5] rust: macros: add derive macro for `TryFrom` Jesung Yang
2025-08-15 5:32 ` [PATCH v2 5/5] rust: macros: add derive macro for `Into` Jesung Yang
2025-08-29 8:38 ` [PATCH v2 0/5] rust: add `TryFrom` and `Into` derive macros Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCDVIR91LFHQ.1C87G5A0OBJ39@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=y.j3ms.n@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).