Re: [PATCH v7 0/6] rust, nova-core: PCI Class, Vendor support

["Alexandre Courbot" <acourbot@nvidia.com>]

On Wed Aug 27, 2025 at 8:12 AM JST, John Hubbard wrote:
> Changes since v6:
>
> * Applied changes from Danilo's and Alex's and Elle's reviews (thanks!):
>     * Rebased onto driver-core-next, which is here:
>           https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
>     * Changed pci::Vendor to be a u16, instead of a u32.
>     * Inlined all of the tiniest functions.
>     * Changed from Class/Vendor new(), to from_raw().
>     * Made from_raw() only accessible to super, which in this case is
>       the pci module.
>     * Restored infallible operations. That causes Alex's request for the
>       following reasonable behavior to work once again:
>
>           from_raw(0x10de).as_raw() == 0x10de
>
>     * Added a new patch, to inline the remaining PCI operations. This
>       provides consistent inline choices throughout pci.rs.

I am far from a PCI expert, but regardless of bus considerations the
code appears to make sense to me (particularly since it removes some
uses of the `bindings` module!). Thus, and FWIW,

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>