* [PATCH] nova-core: Ada: basic GPU identification
@ 2025-10-25 1:20 John Hubbard
2025-10-25 4:05 ` Alexandre Courbot
2025-10-30 11:15 ` Danilo Krummrich
0 siblings, 2 replies; 4+ messages in thread
From: John Hubbard @ 2025-10-25 1:20 UTC (permalink / raw)
To: Danilo Krummrich
Cc: Alexandre Courbot, Joel Fernandes, Timur Tabi, Alistair Popple,
Edwin Peer, Zhi Wang, David Airlie, Simona Vetter, Bjorn Helgaas,
Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, nouveau, rust-for-linux, LKML, John Hubbard
...which is sufficient to make Ada GPUs work, because they use the
pre-existing Ampere GPU code, unmodified.
Tested on AD102 (RTX 6000 Ada).
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
This applies cleanly to today's drm-rust-next.
thanks,
John Hubbard
drivers/gpu/nova-core/falcon/hal.rs | 2 +-
drivers/gpu/nova-core/firmware/gsp.rs | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/nova-core/falcon/hal.rs b/drivers/gpu/nova-core/falcon/hal.rs
index bba288455617..c6c71db1bb70 100644
--- a/drivers/gpu/nova-core/falcon/hal.rs
+++ b/drivers/gpu/nova-core/falcon/hal.rs
@@ -44,7 +44,7 @@ pub(super) fn falcon_hal<E: FalconEngine + 'static>(
use Chipset::*;
let hal = match chipset {
- GA102 | GA103 | GA104 | GA106 | GA107 => {
+ GA102 | GA103 | GA104 | GA106 | GA107 | AD102 | AD103 | AD104 | AD106 | AD107 => {
KBox::new(ga102::Ga102::<E>::new(), GFP_KERNEL)? as KBox<dyn FalconHal<E>>
}
_ => return Err(ENOTSUPP),
diff --git a/drivers/gpu/nova-core/firmware/gsp.rs b/drivers/gpu/nova-core/firmware/gsp.rs
index 6b0761460a57..24c3ea698940 100644
--- a/drivers/gpu/nova-core/firmware/gsp.rs
+++ b/drivers/gpu/nova-core/firmware/gsp.rs
@@ -150,6 +150,7 @@ pub(crate) fn new<'a, 'b>(
let sigs_section = match chipset.arch() {
Architecture::Ampere => ".fwsignature_ga10x",
+ Architecture::Ada => ".fwsignature_ad10x",
_ => return Err(ENOTSUPP),
};
let signatures = elf::elf64_section(fw.data(), sigs_section)
base-commit: d3917368ebc5cd89d7d08eab4673e5c4c73ff42f
--
2.51.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nova-core: Ada: basic GPU identification
2025-10-25 1:20 [PATCH] nova-core: Ada: basic GPU identification John Hubbard
@ 2025-10-25 4:05 ` Alexandre Courbot
2025-10-30 11:15 ` Danilo Krummrich
1 sibling, 0 replies; 4+ messages in thread
From: Alexandre Courbot @ 2025-10-25 4:05 UTC (permalink / raw)
To: John Hubbard, Danilo Krummrich
Cc: Alexandre Courbot, Joel Fernandes, Timur Tabi, Alistair Popple,
Edwin Peer, Zhi Wang, David Airlie, Simona Vetter, Bjorn Helgaas,
Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, nouveau, rust-for-linux, LKML
On Sat Oct 25, 2025 at 10:20 AM JST, John Hubbard wrote:
> ...which is sufficient to make Ada GPUs work, because they use the
> pre-existing Ampere GPU code, unmodified.
>
> Tested on AD102 (RTX 6000 Ada).
>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Thanks - staging for merging soonish.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nova-core: Ada: basic GPU identification
2025-10-25 1:20 [PATCH] nova-core: Ada: basic GPU identification John Hubbard
2025-10-25 4:05 ` Alexandre Courbot
@ 2025-10-30 11:15 ` Danilo Krummrich
2025-10-30 20:09 ` John Hubbard
1 sibling, 1 reply; 4+ messages in thread
From: Danilo Krummrich @ 2025-10-30 11:15 UTC (permalink / raw)
To: John Hubbard
Cc: Alexandre Courbot, Joel Fernandes, Timur Tabi, Alistair Popple,
Edwin Peer, Zhi Wang, David Airlie, Simona Vetter, Bjorn Helgaas,
Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, nouveau, rust-for-linux, LKML
On 10/25/25 3:20 AM, John Hubbard wrote:
> ...which is sufficient to make Ada GPUs work, because they use the
> pre-existing Ampere GPU code, unmodified.
>
> Tested on AD102 (RTX 6000 Ada).
>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Acked-by: Danilo Krummrich <dakr@kernel.org>
You may want to consider requesting committer access for the drm-rust tree [1].
[1]
https://drm.pages.freedesktop.org/maintainer-tools/committer/commit-access.html#access-request
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nova-core: Ada: basic GPU identification
2025-10-30 11:15 ` Danilo Krummrich
@ 2025-10-30 20:09 ` John Hubbard
0 siblings, 0 replies; 4+ messages in thread
From: John Hubbard @ 2025-10-30 20:09 UTC (permalink / raw)
To: Danilo Krummrich
Cc: Alexandre Courbot, Joel Fernandes, Timur Tabi, Alistair Popple,
Edwin Peer, Zhi Wang, David Airlie, Simona Vetter, Bjorn Helgaas,
Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, nouveau, rust-for-linux, LKML
On 10/30/25 4:15 AM, Danilo Krummrich wrote:
> On 10/25/25 3:20 AM, John Hubbard wrote:
>> ...which is sufficient to make Ada GPUs work, because they use the
>> pre-existing Ampere GPU code, unmodified.
>>
>> Tested on AD102 (RTX 6000 Ada).
>>
>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>
> Acked-by: Danilo Krummrich <dakr@kernel.org>
>
> You may want to consider requesting committer access for the drm-rust tree [1].
>
I really appreciate the vote of confidence here! :)
thanks,
--
John Hubbard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-30 20:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-25 1:20 [PATCH] nova-core: Ada: basic GPU identification John Hubbard
2025-10-25 4:05 ` Alexandre Courbot
2025-10-30 11:15 ` Danilo Krummrich
2025-10-30 20:09 ` John Hubbard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).