From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Alexandre Courbot" <acourbot@nvidia.com>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"John Hubbard" <jhubbard@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>, "Edwin Peer" <epeer@nvidia.com>,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
"Danilo Krummrich" <dakr@kernel.org>,
dri-devel <dri-devel-bounces@lists.freedesktop.org>
Subject: Re: [PATCH 7/7] gpu: nova-core: justify remaining uses of `as`
Date: Mon, 27 Oct 2025 21:07:17 +0900 [thread overview]
Message-ID: <DDT3BTI26XFE.1Z5E9QZZJCPHQ@nvidia.com> (raw)
In-Reply-To: <CANiq72m9ms-OznWQ5+4_JvAs4yruwgBRcm1u0gCAnasqO8uJOA@mail.gmail.com>
On Mon Oct 27, 2025 at 1:11 AM JST, Miguel Ojeda wrote:
> On Sun, Oct 26, 2025 at 3:40 PM Alexandre Courbot <acourbot@nvidia.com> wrote:
>>
>> + // `as u32` is used on purpose since we do want to strip the upper bits, which will be
>> + // written to `NV_PFALCON_FALCON_DMATRFBASE1`.
>> .set_base((dma_start >> 8) as u32)
>> .write(bar, &E::ID);
>
> We are not very consistent on this yet, but I would suggest using `//
> CAST:`. We are working on getting `// PANIC:` in Clippy, and we could
> get others like this one eventually.
Sounds great, will do!
next prev parent reply other threads:[~2025-10-27 12:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-26 14:39 [PATCH 0/7] gpu: nova-core: remove use of `as` for integer conversions Alexandre Courbot
2025-10-26 14:39 ` [PATCH 1/7] gpu: nova-core: replace `as` with `from` conversions where possible Alexandre Courbot
2025-10-26 14:39 ` [PATCH 2/7] gpu: nova-core: vbios: remove unneeded u8 conversions Alexandre Courbot
2025-10-26 14:39 ` [PATCH 3/7] gpu: nova-core: vbios: add conversion to u8 for BiosImageType Alexandre Courbot
2025-10-26 14:39 ` [PATCH 4/7] gpu: nova-core: use `try_from` instead of `as` for u32 conversions Alexandre Courbot
2025-10-26 14:39 ` [PATCH 5/7] gpu: nova-core: add extra conversion functions and traits Alexandre Courbot
2025-10-26 15:40 ` Danilo Krummrich
2025-10-27 12:08 ` Alexandre Courbot
2025-10-26 16:44 ` Miguel Ojeda
2025-10-27 12:20 ` Alexandre Courbot
2025-10-27 18:46 ` John Hubbard
2025-10-27 18:58 ` Joel Fernandes
2025-10-28 14:44 ` Alexandre Courbot
2025-10-28 15:12 ` Miguel Ojeda
2025-10-28 17:18 ` John Hubbard
2025-10-28 22:32 ` Alexandre Courbot
2025-10-28 22:40 ` John Hubbard
2025-10-26 14:39 ` [PATCH 6/7] gpu: nova-core: replace use of `as` with functions from `num` Alexandre Courbot
2025-10-26 14:39 ` [PATCH 7/7] gpu: nova-core: justify remaining uses of `as` Alexandre Courbot
2025-10-26 16:11 ` Miguel Ojeda
2025-10-27 12:07 ` Alexandre Courbot [this message]
2025-10-28 14:45 ` Miguel Ojeda
2025-10-26 15:35 ` [PATCH 0/7] gpu: nova-core: remove use of `as` for integer conversions Danilo Krummrich
2025-10-27 12:24 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDT3BTI26XFE.1Z5E9QZZJCPHQ@nvidia.com \
--to=acourbot@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=dri-devel-bounces@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=epeer@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).